Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix minor style issues in net.md and http.md #7528

Closed
wants to merge 2 commits into from
Closed

doc: fix minor style issues in net.md and http.md #7528

wants to merge 2 commits into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jul 4, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc net http

Description of change

@Trott Trott added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Jul 4, 2016
@Trott
Copy link
Member Author

Trott commented Jul 4, 2016

@nodejs/documentation

@addaleax
Copy link
Member

addaleax commented Jul 4, 2016

LGTM but you might want to keep an eye on #7137 which addresses all of the net changes here (although in a slightly different way).

@Trott
Copy link
Member Author

Trott commented Jul 7, 2016

Landing the http stuff only so as not to step on the net changes in #7137.

Trott added a commit to Trott/io.js that referenced this pull request Jul 7, 2016
@Trott
doc: fix minor style issues in http.md
0f3149e 
PR-URL: nodejs#7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@Trott
Copy link
Member Author

Trott commented Jul 7, 2016

Landed in 0f3149e

@Trott Trott closed this Jul 7, 2016
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: fix minor style issues in http.md
8a4a45a 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott @MylesBorins
doc: fix minor style issues in http.md
c93579d 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: fix minor style issues in http.md
d749147 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@Trott
doc: fix minor style issues in http.md
cfcf62d 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
evanlucas pushed a commit that referenced this pull request Jul 13, 2016
@Trott @evanlucas
doc: fix minor style issues in http.md
663b103 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: fix minor style issues in http.md
6c06020 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@Trott
doc: fix minor style issues in http.md
537f333 
PR-URL: #7528
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
Merged
@Trott Trott deleted the netcomma branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Trott @addaleax @MylesBorins