-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
backport 4747, rename .markdown #7507
backport 4747, rename .markdown #7507
Conversation
Original commit: 0800c0a doc: git mv to .md * doc: rename .markdown references in content * doc: rename to .md in tools * doc: rename to .md in CONTRIBUTING.md PR-URL: #4747 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: techjeffharris Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
LGTM |
Curious, is this necessary for backports, or? |
It is as it would block necessary doc additions that happened after the
|
Fwiw git am -3 is able to backport the doc fixes without issue... That
being said it is still nice to have the two branches in sync
|
Your call. LGTY anyone else? |
Decreases some of the backporting pain.
|
Since I am a little busy next week I wanted to merge this today. Can I have another LGTM? @thealphanerd is that fine for you? |
Please hold off on merging this. I'll review it tomorrow when in back to
work 😊.
Thanks!
|
ACK.
|
landed in 84f51b9 |
Original commit:
0800c0a