doc: add added: information for timers
#7493
Conversation
addaleax
added
doc
| @@ -94,6 +106,9 @@ set to `1`. | |||
| If `callback` is not a function, a [`TypeError`][] will be thrown. | |||
|
|
|||
| ### setTimeout(callback, delay[, ...arg]) | |||
| <!-- YAML | |||
| added: v0.0.1 | |||
There was a problem hiding this comment.
Doesn't seem quite right?
I'm pretty sure Isaac added these but that wasn't at the start I think...
The oldest reference I seem to be able to find of it exposed on the global (actually GLOBAL at the time) is 7a2e784 (v0.1.16)
hmmm, Indeed it looks like the original was added before v0.0.1 but I'm not sure it was exposed in a way that uh, counts?
.. also note that (awkwardly) these were actually added to the timers module pretty long after they were available on the global object. They were added to the module in 7994400 (v0.3.1)
There was a problem hiding this comment.
The oldest reference I seem to be able to find of it exposed on the global (actually GLOBAL at the time) is 7a2e784 (v0.1.16)
It was present on the global before; the JS entry point (src/node.js) is executed without the function wrapper, so the functions defined there became part of the global scope.
If you prefer, I can go for the version in which they were added to the timers module, but that’s not the common usage pattern (not that it really matters too much for this old stuff anyway).
|
LGTM |
1 similar comment
|
LGTM |
|
Landed in cd4dbf3 |
Ref: nodejs#6578 PR-URL: nodejs#7493 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Checklist
Affected core subsystem(s)
doc
Description of change
Ref: #6578