Skip to content

inspector: process.exit should wait for inspector #7252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

inspector: process.exit should wait for inspector #7252

wants to merge 1 commit into from

Conversation

eugeneo
Copy link
Contributor

@eugeneo eugeneo commented Jun 9, 2016

Checklist
  • make -j4 test (UNIX) or vcbuild test nosign (Windows) passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

inspector

Description of change

Waits for the inspector frontend to detach when process.exit is called. This enables the user to analyse the profiling information.

Fixes: #7088

@nodejs-github-bot nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Jun 9, 2016
@eugeneo
Copy link
Contributor Author

eugeneo commented Jun 9, 2016

@ofrobots

@pavelfeldman
Copy link
Contributor

lgtm

@ofrobots
Copy link
Contributor

ofrobots commented Jun 9, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2967/

@bnoordhuis
Copy link
Member

LGTM

@bnoordhuis
Copy link
Member

For bonus points: factor out that magic number 32 into a constant and update PlatformInit() and WaitForInspectorDisconnect().

@eugeneo
Copy link
Contributor Author

eugeneo commented Jun 10, 2016

@bnoordhuis I introduced a constant and rebased the CL

bnoordhuis
bnoordhuis reviewed Jun 10, 2016
View reviewed changes
src/node.cc
@@ -187,6 +187,7 @@ static v8::Platform* default_platform;

#ifdef __POSIX__
static uv_sem_t debug_semaphore;
static const short NUM_SIGNALS = 32;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you name it e.g. kNumSignals or kMaxSignal? ALL_CAPS should be reserved for macros. LGTM apart from that.

@eugeneo
Copy link
Contributor Author

eugeneo commented Jun 10, 2016

@bnoordhuis I renamed to kMaxSignal. Thanks!

@ofrobots
Copy link
Contributor

New CI: https://ci.nodejs.org/job/node-test-pull-request/2982/

@bnoordhuis
Copy link
Member

LGTM. ppcbe-ubuntu1404 seems to be stuck but everything else is green.

@ofrobots
Copy link
Contributor

Thanks, landed as 6626919.

@ofrobots ofrobots closed this Jun 13, 2016
ofrobots pushed a commit that referenced this pull request Jun 13, 2016
@ofrobots
inspector: process.exit should wait for inspector
6626919 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
@evanlucas
Copy link
Contributor

I am excluding this one from the next v6.x release since it is just a semver patch release. Once the inspector lands in v6.x, we can remove the dont-land-on-v6.x label. Thanks!

Fishrock123 pushed a commit that referenced this pull request Jul 5, 2016
@Fishrock123
inspector: process.exit should wait for inspector
88b2aa3 
Fixes: #7088
PR-URL: #7252
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>

 Conflicts:
	src/node.cc
@Fishrock123 Fishrock123 mentioned this pull request Jul 5, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
@alexdima alexdima mentioned this pull request Aug 25, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

--inspect connection dies before profiler captures trace
8 participants
@eugeneo @pavelfeldman @ofrobots @bnoordhuis @evanlucas @MylesBorins @Fishrock123 @nodejs-github-bot