Skip to content

Conversation

@imyller
Copy link
Member

@imyller imyller commented Jun 8, 2016

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Fix typo in Node.js core development IRC channel URL

Signed-off-by: Ilkka Myller ilkka.myller@nodefield.com

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Jun 8, 2016
@jasnell
Copy link
Member

jasnell commented Jun 8, 2016

LGTM

2 similar comments
@Trott
Copy link
Member

Trott commented Jun 8, 2016

LGTM

@MylesBorins
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Jun 8, 2016

LGTM and landed in 556dd3b.

@cjihrig cjihrig closed this Jun 8, 2016
cjihrig pushed a commit that referenced this pull request Jun 8, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
evanlucas pushed a commit that referenced this pull request Jun 16, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
MylesBorins pushed a commit that referenced this pull request Jul 11, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
PR-URL: #7210
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants