Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: consolidate test/lint text in GH PR template #7155

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Jun 4, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

@Trott Trott added the doc Issues and PRs related to the documentations. label Jun 4, 2016
@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jun 4, 2016
@addaleax
Copy link
Member

addaleax commented Jun 4, 2016

LGTM

2 similar comments
@Fishrock123
Copy link
Contributor

LGTM

@jasnell
Copy link
Member

jasnell commented Jun 6, 2016

LGTM

julianduque pushed a commit that referenced this pull request Jun 7, 2016
PR-URL: #7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@julianduque
Copy link
Contributor

Landed in 0155744

@julianduque julianduque closed this Jun 7, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
PR-URL: #7155
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
@Trott Trott deleted the tweak branch January 13, 2022 22:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants