Skip to content

test: enable test-debug-brk-no-arg #7143

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

test: enable test-debug-brk-no-arg #7143

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 0 additions & 15 deletions test/disabled/test-debug-brk-no-arg.js
View file
Open in desktop

This file was deleted.

13 changes: 13 additions & 0 deletions test/parallel/test-debug-brk-no-arg.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
'use strict';
const common = require('../common');
const assert = require('assert');
const spawn = require('child_process').spawn;

const child = spawn(process.execPath, ['--debug-brk=' + common.PORT, '-i']);
child.stderr.once('data', common.mustCall(function() {
child.stdin.end('.exit');
}));

child.on('exit', common.mustCall(function(c) {
Copy link
Contributor

@Fishrock123 Fishrock123 Jun 3, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be 'close'?

Copy link
Member Author

@Trott Trott Jun 4, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this particular case, I don't think it matters either way. But I'm happy to change it to close if that is more idiomatic or avoids problems that I'm currently unaware of in the existing code.

assert.strictEqual(c, 0);
}));