-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: add links to platform specific mechanisms #7071
Conversation
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching.
@jasnell as requested in previous PR. |
Can you add the links in the footer instead? An example would be https://github.com/nodejs/node/pull/7071/files#diff-acabf706a8aa070a8796e3573f7e4678R1561 Otherwise LGTM |
nice work, lgtm, that apple url tho .. |
@rvagg Too short? |
@mscdex yeah, that, obviously, I was also wondering how stable the named anchors are |
I'd suggest using http://illumos.org/man/port_create as the link for event ports. |
How about moving these links to the bottom of this documentation to define, that might be readable to maintainers or source reader :-) |
@eljefedelrodeodeljefe did you get the wrong link for the example ? |
Figured it out. Good to learn how to put links at the bottom. Pushed update. |
lgtm :-) |
👍 |
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching. PR-URL: #7071 Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
landed as 138c7af |
As requested in earlier PR adding detail for Aix, add link for each of the platform specific technologies used for file system watching. PR-URL: #7071 Reviewed-By: Robert Jefe Lindstädt <robert.lindstaedt@gmail.com> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Yorkie Liu <yorkiefixer@gmail.com>
Checklist
Affected core subsystem(s)
fs
Description of change
As requested in earlier PR adding detail for Aix, add link
for each of the platform specific technologies used for
file system watching.
Note I did not find a good link for "event ports" on Solaris. Hoping @davepacheco might be able to suggest one.