doc: general improvements to punycode.md copy #7025
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| const punycode = require('punycode'); | ||
| ``` | ||
|
|
||
| [Punycode][] is a character encoding scheme defined by RFC 3492 that is |
There was a problem hiding this comment.
There was a problem hiding this comment.
Oh. Hmm. I find that a bit confusing, oh well.
mscdex
added
the
lib / src
|
Generally LGTM |
jasnell
force-pushed
the
doc-punycode-copy
branch
from
ba98639
to
a348b63
Compare
jasnell
added a commit
that referenced
this pull request
Jun 2, 2016
PR-URL: #7025 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
|
Landed in 83e3226 |
evanlucas
pushed a commit
that referenced
this pull request
Jun 15, 2016
PR-URL: #7025 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc (punycode)
Description of change
General improvements to punycode.md copy
@nodejs/documentation