doc: add added: information for vm
#7011
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addaleax
added
doc
36 tasks
| @@ -201,6 +219,9 @@ window's global object, then run all `<script>` tags together within the context | |||
| of that sandbox. | |||
|
|
|||
| ## vm.isContext(sandbox) | |||
| <!-- YAML | |||
| added: v1.0.0 | |||
There was a problem hiding this comment.
vm.isContext() was added in v0.11.7. (EDIT: Commit 9c110d8.)
|
LGTM with a comment. |
|
Updated with @bnoordhuis’ correction |
|
LGTM |
1 similar comment
|
LGTM |
|
@julianduque Sorry for getting in the way here, but I force-pushed to master to fix metadata from #6995 … Will re-land this myself, though :) |
|
race condition |
|
16f98e5 it is :) |
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
May 30, 2016
Ref: nodejs#6578 PR-URL: nodejs#7011 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julian Duque <julianduquej@gmail.com>
addaleax
added a commit
to addaleax/node
that referenced
this pull request
Jul 12, 2016
Ref: nodejs#6578 PR-URL: nodejs#7011 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julian Duque <julianduquej@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc, vm
Description of change
Ref: #6578