Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add added: information for path #6985

Closed
wants to merge 1 commit into from
Closed

doc: add added: information for path #6985

wants to merge 1 commit into from

Conversation

julianduque
Copy link
Contributor

@julianduque julianduque commented May 26, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • the commit message follows commit guidelines
Affected core subsystem(s)

doc, path

Description of change

Add added: information for path.

Got the information from git history mostly, I ignored previous path
methods attached to node.path (pre v0.1.16).

Ref: #6578

@julianduque
doc: add added: information for path
9725976 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Ref: nodejs#6578
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label May 26, 2016
@mscdex mscdex added the path Issues and PRs related to the path subsystem. label May 26, 2016
@addaleax
Copy link
Member

LGTM and thanks for this!

@sam-github sam-github mentioned this pull request May 26, 2016
Closed
36 tasks
@jasnell
Copy link
Member

jasnell commented May 26, 2016

LGTM
@mscdex and @bnoordhuis ... do the versions look correct?

@julianduque
Copy link
Contributor Author

Any objection to merge this?

jasnell pushed a commit that referenced this pull request Jun 3, 2016
@julianduque @jasnell
doc: add added: information for path
bed44c9 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@jasnell
Copy link
Member

jasnell commented Jun 3, 2016

Landed in bed44c9

@jasnell jasnell closed this Jun 3, 2016
evanlucas pushed a commit that referenced this pull request Jun 15, 2016
@julianduque @evanlucas
doc: add added: information for path
a7c85e6 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Jun 16, 2016
Merged
@MylesBorins MylesBorins mentioned this pull request Jul 11, 2016
Closed
addaleax pushed a commit to addaleax/node that referenced this pull request Jul 12, 2016
@julianduque @addaleax
doc: add added: information for path
aed035a 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: nodejs#6578
PR-URL: nodejs#6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@julianduque
doc: add added: information for path
d2c090f 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 12, 2016
@julianduque
doc: add added: information for path
482f08e 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jul 12, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@julianduque
doc: add added: information for path
057492c 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jul 14, 2016
@julianduque
doc: add added: information for path
f1a37ad 
Got the information from git history mostly, I ignored previous path
methods attached to `node.path` (pre v0.1.16).

Refs: #6578
PR-URL: #6985
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@julianduque @addaleax @jasnell @mscdex @MylesBorins @nodejs-github-bot