New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

child_process: allow buffer encoding in spawnSync #6939

Closed

cjihrig wants to merge 2 commits into nodejs:master from cjihrig:6930

Contributor

cjihrig commented May 23, 2016

Checklist

tests and code linting passes
a test and/or benchmark is included
the commit message follows commit guidelines

Affected core subsystem(s)

child_process

Description of change

When the 'buffer' encoding is passed to spawnSync(), an exception is thrown in Buffer's toString() method because 'buffer' is not a valid encoding there. This commit special cases the 'buffer' encoding.

Fixes: #6930

cjihrig added 2 commits

May 23, 2016 17:20


          child_process: allow buffer encoding in spawnSync

822dd87

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.


          test: refactor spawnSync() cwd test

55c3c3c

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

nodejs-github-bot added the child_process label

cjihrig added the test label

Member

addaleax commented May 23, 2016

LGTM pending CI

Member

bnoordhuis commented May 24, 2016

LGTM

Contributor Author

cjihrig commented May 24, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2762/

cjihrig added a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

dc76aff

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

cjihrig added a commit that referenced this pull request


          test: refactor spawnSync() cwd test

6bad85c

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Contributor Author

cjihrig commented May 24, 2016

Thanks for the reviews. Landed in dc76aff and 6bad85c.

cjihrig closed this

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request


          child_process: allow buffer encoding in spawnSync

1009f9a

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: nodejs#6930
PR-URL: nodejs#6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request


          test: refactor spawnSync() cwd test

52b5b67

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: nodejs#6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

b28468e

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

rvagg pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

69e119d

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins mentioned this pull request

Audit commits not found on v4.x-staging #7116

Closed

MylesBorins added the lts-watch-v4.x label

Contributor

MylesBorins commented Jun 3, 2016

cjihrig deleted the 6930 branch

June 3, 2016 01:56

Contributor Author

cjihrig commented Jun 3, 2016

Yep

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

819a71a

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

beb3f0e

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins added land-on-v4.x and removed lts-watch-v4.x labels

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

31771ba

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

0c3f534

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

583e5f1

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

083888f

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

8d9f626

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

fb18096

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins mentioned this pull request

v4.5.0 proposal #7688

Merged

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

6daebb0

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

830675e

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          child_process: allow buffer encoding in spawnSync

4ee863d

When the 'buffer' encoding is passed to spawnSync(), an exception
is thrown in Buffer's toString() method because 'buffer' is not
a valid encoding there. This commit special cases the 'buffer'
encoding.

Fixes: #6930
PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

MylesBorins pushed a commit that referenced this pull request


          test: refactor spawnSync() cwd test

ecf5c1c

This commit refactors test-child-process-spawnsync.js to use
the reusable common.spawnSyncPwd().

PR-URL: #6939
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

child_process test