tools: disallow multiple spaces except for indentation #6645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for stricter linting, remove extra spaces.
Except for indentation, disallow multiple whitespace around logical expressions, conditional expressions, declarations, array elements, object properties, sequences and function parameters.
|
Totally +1 on this. LGTM if CI is happy |
|
LGTM if CI is good: https://ci.nodejs.org/job/node-test-pull-request/2542/ |
|
Only CI failure is a known flaky that will be fixed when #6633 lands. |
|
By the way, I used the |
|
LGTM |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 12, 2016
In preparation for stricter linting, remove extra spaces. PR-URL: nodejs#6645 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 12, 2016
Except for indentation, disallow multiple whitespace around logical expressions, conditional expressions, declarations, array elements, object properties, sequences and function parameters. PR-URL: nodejs#6645 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
In preparation for stricter linting, remove extra spaces. PR-URL: #6645 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
Except for indentation, disallow multiple whitespace around logical expressions, conditional expressions, declarations, array elements, object properties, sequences and function parameters. PR-URL: #6645 Reviewed-By: Michaël Zasso <mic.besace@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Roman Reiss <me@silverwind.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tools test benchmark lib
Description of change
Except for indentation, disallow multiple whitespace around logical
expressions, conditional expressions, declarations, array elements,
object properties, sequences and function parameters.
This stems from comments in #6592
where five collaborators expressed frustration with the use of spaces to
align things that do not appear first on a line. I would not be surprised if there
are others who feel differently, but rather than make an assumption, I'm
putting this out there and we'll see....
Anyway, @cjihrig probably stated the argument for this rule the clearest:
/cc @jasnell @targos @mscdex @jbergstroem @cjihrig