test: fix unreliable known_issues test #6555
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
2 tasks
| console.log(exponent); | ||
| const longLine = lineSeed.repeat(Math.pow(2, exponent)); | ||
| const cmd = `${process.execPath} ${__filename} child ${exponent}`; | ||
| const stdout = execSync(cmd).toString().trim(); |
There was a problem hiding this comment.
Can't you just calculate Math.pow(2, exponent) once in the parent and pass it as argument to the child?
|
LGTM with a comment |
| const cmd = `${process.execPath} ${__filename} child`; | ||
| const stdout = execSync(cmd).toString().trim(); | ||
| [16, 18, 20].forEach((exponent) => { | ||
| console.log(exponent); |
There was a problem hiding this comment.
Is the console.log() needed, or can it be dropped?
There was a problem hiding this comment.
I don’t know if it’s needed, but I’d like to have some way of knowing at what length the test failed after it has run.
There was a problem hiding this comment.
I accidentally left it in from debugging. I can add it to the assert message, perhaps.
|
LGTM with nits addressed. |
|
LGTM, maybe with @santigimeno’s nit addressed if that works too. |
|
Nits addressed. |
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527
| [16, 18, 20].forEach((exponent) => { | ||
| const bigNum = Math.pow(2, exponent); | ||
| const longLine = lineSeed.repeat(bigNum); | ||
| const cmd = `${process.execPath} ${__filename} child ${exponent} ${bigNum}`; |
There was a problem hiding this comment.
I think the exponent argument is not needed anymore
There was a problem hiding this comment.
Strictly speaking, that's true, but I left it in for the assert message.
|
Still LGTM with one nit |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
May 6, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: nodejs#6527 PR-URL: nodejs#6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in c4006dd |
evanlucas
pushed a commit
that referenced
this pull request
May 17, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
@Trott lts? |
|
@thealphanerd Yes |
MylesBorins
pushed a commit
that referenced
this pull request
Jun 14, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jun 24, 2016
`test-stdout-buffer-flush-on-exit` was not failing reliably on POSIX machines and not failing at all on Windows. Revised test fails reliably on POSIX and is skipped (in CI) on Windows where the issue does not exist. Fixes: #6527 PR-URL: #6555 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Joao Reis <reis@janeasystems.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
test-stdout-buffer-flush-on-exitwas not failing reliably on POSIXmachines and not failing at all on Windows. Revised test fails reliably
on POSIX and is skipped (in CI) on Windows where the issue does not
exist.
Fixes: #6527