Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: update authors file #6373

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Apr 25, 2016

Affected core subsystem(s)

meta

Description of change

Update the authors file for v6 ... ~119 new contributors since this was last updated!

@jasnell jasnell added the meta Issues and PRs related to the general management of the project. label Apr 25, 2016
@jasnell jasnell added this to the 6.0.0 milestone Apr 25, 2016
Ben Ripkens <bripkens.dev@gmail.com>
Ryan Sobol <contact@ryansobol.com>
jona <jona@jona.io>
Anna Henningsen <sqrt@entless.org>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell You can remove this line, I feel fine being listed once, but thanks. 😄

@jasnell
Copy link
Member Author

jasnell commented Apr 25, 2016

done! removed a couple other duplicates that I noticed as well

Vitor Cortez <vitoracortez+github@gmail.com>
Michael Theriot <michael.lee.theriot@gmail.com>
Peter Geiss <peter.w.geiss@gmail.com>
Santiago Gimeno <santiago.gimeno@ionide.es>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can remove this entry. I'm already added with a different email, I committed only once with this by mistake.

@MylesBorins
Copy link
Contributor

@jasnell I think the dupes can be added to https://github.com/nodejs/node/blob/master/.mailmap

@@ -701,7 +701,6 @@ Mathias Küsel <mathiask@hotmail.de>
Qasim Zaidi <qasim@zaidi.me>
Sam Newman <newmansam@outlook.com>
Zach Bruggeman <mail@bruggie.com>
Michaël Zasso <mic.besace@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any reason for moving duplicates to the bottom? The list should be ordered, afaik, and this commit actually moves some contributors down.

@jasnell
Copy link
Member Author

jasnell commented Apr 25, 2016

Thanks! Additional cleanups pushed. Keep the fixes coming! :-)

@@ -831,7 +831,6 @@ Claudio Rodriguez <cjrodr@yahoo.com>
Ido Ben-Yair <idoby@wix.com>
Kyle Smith <kyle.r.smiff@gmail.com>
Marti Martz <thalamew@q.com>
Stefan Budeanu <stefan@budeanu.com>
Copy link
Member

@ChALkeR ChALkeR Apr 25, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same: moved for some reason to Stefan Budeanu <stefanbu@ca.ibm.com> a bit lower.

Hideki Yamamura <hideki.yamamura@gmail.com>
Lenny Markus <lmarkus@paypal.com>
Nelson Pecora <nelson@yoshokatana.com>
Xotic750 <xotic750@gmail>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GitHub profile says Graham Fairweather. Also, the email is incorrect (misses the .com).
/cc @Xotic750

Andrea Giammarchi <andrea.giammarchi@gmail.com>
Lance Ball <lball@redhat.com>
Jarrett Widman <jarrett@24m2.com>
Florian MARGAINE <florian@margaine.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably be Florian Margaine? @ralt

Copy link
Contributor

@ralt ralt Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the capitalized (and not uppercased) version better, but I don't really care either way tbh

Copy link
Member

@ChALkeR ChALkeR Apr 26, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jasnell That means that this line should be fixed to Florian Margaine.
Ah, sorry, it's already fixed =). Thanks!

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Updated and squashed. Will be landing this shortly. Last call for additional edits.

Ilya Shaisultanov <ishaisultanov@shutterstock.com>
James Lal <james@silklabs.com>
Josh Leder <josh@ha.cr>
surya panikkal <surya.com@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/cc @suryagh. Is that the preferred name?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChALkeR yes, thank you.

@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Will be landing this in about twenty minutes or so

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

LGTM

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

Wait, give me two more minutes.

Craig Akimoto <strawbrary@users.noreply.github.com>
Michael Barrett <mike182uk@gmail.com>
Alexander Marchenko <axvmindaweb@gmail.com>
Steve Mao <maochenyan@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Steve Mao <maochenyan@msn.com>
Steve Mao <maochenyan@gmail.com>

Duplicates?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

likely

@ChALkeR
Copy link
Member

ChALkeR commented Apr 26, 2016

@jasnell I highlighted some new entries that are likely duplicates.
Otherwise, LGTM. Actually, it's LGTM even with the duplicates — we can sort those out later.
There are some older duplicates already, e.g. @bnoordhuis is mentioned two times.

~116 new contributors since this was last updated!
@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

OK... updated and landing!

jasnell added a commit that referenced this pull request Apr 26, 2016
~116 new contributors since this was last updated!

PR-URL: #6373
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Apr 26, 2016

Landed in a026cd0

@jasnell jasnell closed this Apr 26, 2016
jasnell added a commit that referenced this pull request Apr 26, 2016
~116 new contributors since this was last updated!

PR-URL: #6373
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 1, 2016
~116 new contributors since this was last updated!

PR-URL: #6373
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jun 24, 2016
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
~116 new contributors since this was last updated!

PR-URL: #6373
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jun 24, 2016
~116 new contributors since this was last updated!

PR-URL: #6373
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
@ChALkeR ChALkeR mentioned this pull request Aug 30, 2016
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.