-
Notifications
You must be signed in to change notification settings - Fork 29.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: update authors file #6373
doc: update authors file #6373
Conversation
Ben Ripkens <bripkens.dev@gmail.com> | ||
Ryan Sobol <contact@ryansobol.com> | ||
jona <jona@jona.io> | ||
Anna Henningsen <sqrt@entless.org> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell You can remove this line, I feel fine being listed once, but thanks. 😄
done! removed a couple other duplicates that I noticed as well |
Vitor Cortez <vitoracortez+github@gmail.com> | ||
Michael Theriot <michael.lee.theriot@gmail.com> | ||
Peter Geiss <peter.w.geiss@gmail.com> | ||
Santiago Gimeno <santiago.gimeno@ionide.es> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove this entry. I'm already added with a different email, I committed only once with this by mistake.
@jasnell I think the dupes can be added to https://github.com/nodejs/node/blob/master/.mailmap |
@@ -701,7 +701,6 @@ Mathias Küsel <mathiask@hotmail.de> | |||
Qasim Zaidi <qasim@zaidi.me> | |||
Sam Newman <newmansam@outlook.com> | |||
Zach Bruggeman <mail@bruggie.com> | |||
Michaël Zasso <mic.besace@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for moving duplicates to the bottom? The list should be ordered, afaik, and this commit actually moves some contributors down.
Thanks! Additional cleanups pushed. Keep the fixes coming! :-) |
@@ -831,7 +831,6 @@ Claudio Rodriguez <cjrodr@yahoo.com> | |||
Ido Ben-Yair <idoby@wix.com> | |||
Kyle Smith <kyle.r.smiff@gmail.com> | |||
Marti Martz <thalamew@q.com> | |||
Stefan Budeanu <stefan@budeanu.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same: moved for some reason to Stefan Budeanu <stefanbu@ca.ibm.com>
a bit lower.
7da4fd4
to
c7066fb
Compare
Hideki Yamamura <hideki.yamamura@gmail.com> | ||
Lenny Markus <lmarkus@paypal.com> | ||
Nelson Pecora <nelson@yoshokatana.com> | ||
Xotic750 <xotic750@gmail> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GitHub profile says Graham Fairweather. Also, the email is incorrect (misses the .com
).
/cc @Xotic750
Andrea Giammarchi <andrea.giammarchi@gmail.com> | ||
Lance Ball <lball@redhat.com> | ||
Jarrett Widman <jarrett@24m2.com> | ||
Florian MARGAINE <florian@margaine.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should probably be Florian Margaine? @ralt
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the capitalized (and not uppercased) version better, but I don't really care either way tbh
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jasnell That means that this line should be fixed to Florian Margaine
.
Ah, sorry, it's already fixed =). Thanks!
Updated and squashed. Will be landing this shortly. Last call for additional edits. |
Ilya Shaisultanov <ishaisultanov@shutterstock.com> | ||
James Lal <james@silklabs.com> | ||
Josh Leder <josh@ha.cr> | ||
surya panikkal <surya.com@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @suryagh. Is that the preferred name?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ChALkeR yes, thank you.
Will be landing this in about twenty minutes or so |
LGTM |
Wait, give me two more minutes. |
Craig Akimoto <strawbrary@users.noreply.github.com> | ||
Michael Barrett <mike182uk@gmail.com> | ||
Alexander Marchenko <axvmindaweb@gmail.com> | ||
Steve Mao <maochenyan@gmail.com> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Steve Mao <maochenyan@msn.com>
Steve Mao <maochenyan@gmail.com>
Duplicates?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
likely
@jasnell I highlighted some new entries that are likely duplicates. |
~116 new contributors since this was last updated!
OK... updated and landing! |
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Landed in a026cd0 |
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
~116 new contributors since this was last updated! PR-URL: #6373 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Affected core subsystem(s)
meta
Description of change
Update the authors file for v6 ... ~119 new contributors since this was last updated!