Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test,vm: enable strict mode for vm tests #6209

Closed
wants to merge 1 commit into from
Closed

test,vm: enable strict mode for vm tests #6209

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 15, 2016

Checklist
  • tests and code linting passes
  • the commit message follows commit guidelines
Affected core subsystem(s)

test vm

Description of change

Some vm tests are not in strict mode because they need to create and use global variables. By using global.foo instead of just foo, we can still enable strict mode.

@Trott Trott added vm Issues and PRs related to the vm subsystem. test Issues and PRs related to the tests. labels Apr 15, 2016
@Trott
Copy link
Member Author

Trott commented Apr 15, 2016

CI: https://ci.nodejs.org/job/node-test-pull-request/2267/

@jasnell
Copy link
Member

jasnell commented Apr 15, 2016

LGTM

bnoordhuis
bnoordhuis reviewed Apr 15, 2016
View reviewed changes
test/parallel/test-vm-new-script-new-context.js


console.error('pass values in and out');
code = 'foo = 1;' +
global.code = 'foo = 1;' +
'bar = 2;' +
'if (baz !== 3) throw new Error(\'test fail\');';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you line these up?

@bnoordhuis
Copy link
Member

LGTM with nits.

@Fishrock123
Copy link
Contributor

LGTM with nits & CI

@Trott
test,vm: enable strict mode for vm tests
aed94fe 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.
@Trott
Copy link
Member Author

Trott commented Apr 15, 2016

Alignment nits corrected.

CI: https://ci.nodejs.org/job/node-test-commit/2937/

@Trott
Copy link
Member Author

Trott commented Apr 15, 2016

(Also, wrote a lint rule for that multiline alignment thing so maybe I can stop messing that up on every single commit...)

@santigimeno
Copy link
Member

LGTM

1 similar comment
@JungMinu
Copy link
Member

LGTM

@Trott
Copy link
Member Author

Trott commented Apr 18, 2016

CI one more time: https://ci.nodejs.org/job/node-test-commit/2947/

Trott added a commit to Trott/io.js that referenced this pull request Apr 18, 2016
@Trott
test,vm: enable strict mode for vm tests
15f13cd 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: nodejs#6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 18, 2016

Landed in 15f13cd

@Trott Trott closed this Apr 18, 2016
MylesBorins pushed a commit that referenced this pull request Apr 19, 2016
@Trott
test,vm: enable strict mode for vm tests
8fdda0e 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test,vm: enable strict mode for vm tests
b60df86 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test,vm: enable strict mode for vm tests
c1c3585 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Apr 20, 2016
Closed
MylesBorins pushed a commit that referenced this pull request Apr 20, 2016
@Trott
test,vm: enable strict mode for vm tests
d809c84 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
This was referenced Apr 21, 2016
Closed
Closed
Closed
@MylesBorins
Copy link
Contributor

@Trott lts?

MylesBorins pushed a commit that referenced this pull request Apr 21, 2016
@Trott @MylesBorins
test,vm: enable strict mode for vm tests
01d4522 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@Trott
Copy link
Member Author

Trott commented Apr 21, 2016

@thealphanerd Yes, if it lands cleanly.

joelostrowski pushed a commit to joelostrowski/node that referenced this pull request Apr 25, 2016
@Trott @joelostrowski
test,vm: enable strict mode for vm tests
cc394e4 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: nodejs#6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
jasnell pushed a commit that referenced this pull request Apr 26, 2016
@Trott @jasnell
test,vm: enable strict mode for vm tests
ba63e40 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 17, 2016
@Trott
test,vm: enable strict mode for vm tests
ff2f462 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2016
@Trott
test,vm: enable strict mode for vm tests
9222689 
Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.

PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 18, 2016
Merged
@Trott Trott deleted the vm-strict branch July 31, 2018 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test Issues and PRs related to the tests. vm Issues and PRs related to the vm subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@Trott @jasnell @bnoordhuis @Fishrock123 @santigimeno @JungMinu @MylesBorins