build: run embedtest with node_g when BUILDTYPE=Debug #60850
Merged
+17
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
build
legendecas
force-pushed
the
embed-debug
branch
from
8f04d59 to
ddaf916
Compare
legendecas
force-pushed
the
embed-debug
branch
from
ddaf916 to
93a583e
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60850 +/- ##
==========================================
- Coverage 88.56% 88.04% -0.53%
==========================================
Files 703 703
Lines 208291 208291
Branches 40169 40087 -82
==========================================
- Hits 184472 183384 -1088
- Misses 15831 16847 +1016
- Partials 7988 8060 +72 🚀 New features to boost your workflow:
|
legendecas
force-pushed
the
embed-debug
branch
2 times, most recently
from
e7de0f6 to
c03895a
Compare
cjihrig
approved these changes
Nov 25, 2025
legendecas
force-pushed
the
embed-debug
branch
from
c03895a to
283ff98
Compare
vmoroz
approved these changes
Nov 25, 2025
jakecastelli
added
the
author ready
legendecas
force-pushed
the
embed-debug
branch
from
283ff98 to
936cdea
Compare
Collaborator
Collaborator
Collaborator
Member
Author
cjihrig
approved these changes
Dec 1, 2025
legendecas
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 28142a6 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests should run with the
nodeexe built in the specifiedBUILDTYPE.This depends on #60806.
Refs: #60806 (comment)