Skip to content

Conversation

@aduh95
Copy link
Contributor

@aduh95 aduh95 commented Nov 15, 2025

Another followup of #60125

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Nov 15, 2025
@codecov
Copy link

codecov bot commented Nov 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.57%. Comparing base (0db1c6e) to head (17fba60).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #60726      +/-   ##
==========================================
+ Coverage   88.55%   88.57%   +0.02%     
==========================================
  Files         703      703              
  Lines      208256   208256              
  Branches    40155    40158       +3     
==========================================
+ Hits       184418   184469      +51     
+ Misses      15841    15824      -17     
+ Partials     7997     7963      -34     

see 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Nov 15, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 15, 2025
@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

PR-URL: nodejs#60726
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@aduh95 aduh95 force-pushed the must-call-mustCalls-f branch from 5f9575d to 17fba60 Compare November 17, 2025 21:11
@aduh95
Copy link
Contributor Author

aduh95 commented Nov 17, 2025

Landed in 17fba60

@aduh95 aduh95 merged commit 17fba60 into nodejs:main Nov 17, 2025
21 checks passed
@aduh95 aduh95 deleted the must-call-mustCalls-f branch November 17, 2025 21:11
targos pushed a commit that referenced this pull request Nov 27, 2025
PR-URL: #60726
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants