Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V5.10.1 proposal #6060

Merged
merged 30 commits into from
Apr 5, 2016
Merged

V5.10.1 proposal #6060

merged 30 commits into from
Apr 5, 2016

Conversation

MylesBorins
Copy link
Contributor

2016-04-05, Version 5.10.1 (Stable), @thealphanerd

Notable changes

http:

  • Enclose IPv6 Host header in square brackets. This will enable proper seperation of the host adress from any port reference (Mihai Potra) #5314

path:

  • Make win32.isAbsolute more consistent (Brian White) #6028

Commits

  • [0f5a51ae4b] - assert: Check typed array view type in deepEqual (Anna Henningsen) #5910
  • [e966d1f5db] - buffer: don't set kNoZeroFill flag in allocUnsafe (Vladimir Kurchatkin) #6007
  • [3f75751c2e] - build: introduce ci targets for lint/benchmark (Johan Bergström) #5921
  • [781290b61d] - doc: refine child_process detach behaviour (Robert Jefe Lindstaedt) #5330
  • [aa9fb03202] - doc: use HTTPS for links where possible (Rich Trott) #6019
  • [dd25984838] - doc: note assert.throws() pitfall (Rich Trott) #6029
  • [f879f5e68a] - doc: document unspecified behavior for buf.write* methods (James M Snell) #5925
  • [f12c3861e0] - doc: clarify stdout/stderr arguments to callback (James M Snell) #6015
  • [ce173716be] - doc: add 'Command Line Options' to 'View on single page' (firedfox) #6011
  • [7337ef6422] - doc: minor argument formatting in stream.markdown (James M Snell) #6016
  • [0ae5d027c6] - doc: clarify that __dirname is module local (James M Snell) #6018
  • [8bec8aa41f] - doc: consolidate timers docs in timers.markdown (Bryan English) #5837
  • [0a13099c42] - etw: add event messages (João Reis) #5936
  • [c6ac6f2ea1] - http: Corrects IPv6 address in Host header (Mihai Potra) #5314
  • [8317778925] - meta: add "joining a wg" section to WORKING_GROUPS.md (Matteo Collina) #5488
  • [f3f19ee5e2] - net: refactor self=this to arrow functions (Benjamin Gruenbaum) #5857
  • [1c4007927d] - path: fix win32.isAbsolute() inconsistency (Brian White) #6028
  • [059b607a4f] - test: make use of globals explicit (Rich Trott) #6014
  • [cc8fcc5a07] - test: be explicit about polluting of global (Rich Trott) #6017
  • [7db7a820b9] - test: make arch available in status files (Santiago Gimeno) #5997
  • [02f2ebd9b4] - test: explicitly set global in test-repl (Rich Trott) #6026
  • [2ab1237137] - test: fix flaky test-net-socket-timeout-unref (Rich Trott) #6003
  • [0127c2bd39] - test: fix test-dns.js flakiness (Rich Trott) #5996
  • [6052ced37f] - test: fix error message checks in test-module-loading (James M Snell) #5986
  • [a40b0cb673] - test: refactor http-end-throw-socket-handling (Santiago Gimeno) #5676
  • [96bb315262] - test: ensure _handle property existence (Rich Trott) #5916
  • [4f1fa2adeb] - test: fix offending max-len linter error (Sakthipriyan Vairamani) #5980
  • [f14d71ccea] - test: stdin is not always a net.Socket (Jeremiah Senkpiel) #5935
  • [50a062e691] - tools: remove obsolete lint config file (Rich Trott) #5959
  • [7491fdcfe9] - tools: remove disabling of already-disabled rule (Rich Trott) #6013

benjamingr and others added 29 commits April 5, 2016 10:29
Refactor unused self=this code to code without without this pattern
making it more consistent with the rest of our code.

PR-URL: #5857
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #5936
`<`-ing a file into stdin actually results in a `fs.ReadStream`, rather
than a `tty.ReadStream`, and as such does not inherit from net.Socket,
unlike the other possible stdin options.

Refs: #5916
PR-URL: #5935
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Refer: #5935
PR-URL: #5980
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Phillip Johnsen <johphi@gmail.com>
`test-stdtout-close-unref.js` will fail if `process.stdin._handle` does
not exist. On UNIX-like operating systems, you can see this failure this
way:

    ./node test/parallel/test-stdout-close-unref.js < /dev/null

This issue has been experienced by @bengl and @drewfish in a Docker
container. I'm not sure why they are experiencing it in their
environment, but since it is possible that the `_handle` property does
not exist, let's use `child_process.spawn()` to make sure it exists.

PR-URL: #5916
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
IPv6 addresses in Host header (URI), must be enclosed within
square brackets, in order to properly separate the host address
from any port reference.

PR-URL: #5314
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Introduce two new targets we will populate with actions
once merged into all branches we need to support through CI.

PR-URL: #5921
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Remove timer to avoid the test timing out occasionally.

PR-URL: #5676
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Rather than attempting to keep two versions of docs for timers up to
date, keep them in timers.markdown, and leave references to them in
globals.markdown.

Add setImmediate and clearImmediate to globals.markdown.

Change "To schedule" to "Schedules" in timers.markdown.

PR-URL: #5837
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Fixes: #5525
PR-URL: #6018
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fixes: #4350
PR-URL: #6016
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
`require-buffer` is only enabled in the `lib` directory. There is no
need to disable it in `test`.

PR-URL: #6013
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Includes cli.markdown in all.markdown

PR-URL: #6011
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Clarify that the arguments to child_process.execFile
and child_process.exec callback can be Buffer or strings.

Fixes: #3389
PR-URL: #6015
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Per #1161, when the
buf.write*() methods are given anything other than what
they expect, indicate that the behavior is unspecified.

Fixes: #1161
PR-URL: #5925
Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
PR-URL: #5986
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use empty string instead of `www.google.com` for tests where we are just
doing parameter evaluation. This will avoid DNS lookups which appear to
be causing flakiness on Raspberry Pi devices in CI.

PR-URL: #5996
Fixes: #5554
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #6029
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Throw immediately on socket timeout rather than checking boolean in exit
handler.

PR-URL: #6003
Fixes: #5128
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Provide encrypted links to freenode IRC.

PR-URL: #6019
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Roman Klauke <romaaan.git@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This commit fixes an inconsistency in absolute path checking compared
to the absolute path detection used by the other path.win32 functions.

Fixes: #6027
PR-URL: #6028
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The test intentionally assigns a global. Use `global` namespace to make
it clear that it is intentional and not an accidental leak.

PR-URL: #6026
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The value is retrieved from `process.arch` in node itself.

PR-URL: #5997
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
There was a comment in `test-domain-crypto.js` indicating that the
pollution of the `global` object with a `domain` property was
intentional. Provide more information in the comment so someone may
easily determine why. Use `global.domain` rather than declaring `domain`
without the `var` keyword to more clearly signal that the pollution is
intentional.

PR-URL: #6017
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use `global` to be explicit that a global variable is intended.

PR-URL: #6014
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Do not convert typed arrays to `Buffer` for deepEqual since
their values may not be accurately represented by 8-bit ints.
Instead perform binary comparison of underlying `ArrayBuffer`s,
but only when the array types match.

Never apply any kind of optimization for floating-point typed
arrays since bit pattern equality is not the right kind of check
for them.

PR-URL: #5910
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Fixes: #5907
All JS files have been moved out of the `src` directory so the
`.eslintrc` file in that directory can also be removed.

PR-URL: #5959
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
In the WORKING_GROUPS.md documentation, it is described how to start a
wg, but not how to join an existing wg. This commit addresses that
issue.

Fixes: #5448
PR-URL: #5488
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
this adds an example of a long running node process that actually
executes node code.
Also it mentions the not to harmonic detach behaviours of the
different platforms, whereas detaching on unix requires ignoring
the child_process' stdio explicitely.

PR-URL: #5330
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins added the meta Issues and PRs related to the general management of the project. label Apr 5, 2016
@MylesBorins
Copy link
Contributor Author

ci: https://ci.nodejs.org/job/node-test-pull-request/2166/

citgm: https://ci.nodejs.org/job/thealphanerd-smoker/183/

edit:

re running arm fanned tests --> https://ci.nodejs.org/job/node-test-commit-arm-fanned/2131/
citgm looks good... failures are all expected

arm fanned looks good... moving forwad with release

@Fishrock123
Copy link
Contributor

LGTM

@mscdex
Copy link
Contributor

mscdex commented Apr 5, 2016

It looks like the notable changes section has a formatting issue, path: should be on a separate line.

Notable changes:

http:
  * Enclose IPv6 Host header in square brackets. This will enable
  proper seperation of the host adress from any port reference
  (Mihai Potra) #5314

path:
  * Make win32.isAbsolute more consistent (Brian White)
  #6028

PR-URL: #6060
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Apr 5, 2016 via email

@MylesBorins MylesBorins merged commit 5c4a414 into v5.x Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
MylesBorins pushed a commit that referenced this pull request Apr 5, 2016
Notable changes:

http:
  * Enclose IPv6 Host header in square brackets. This will enable
  proper seperation of the host adress from any port reference
  (Mihai Potra) #5314

path:
  * Make win32.isAbsolute more consistent (Brian White)
  #6028

PR-URL: #6060
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@MylesBorins MylesBorins deleted the v5.10.1-proposal branch April 8, 2016 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.