V5.10.1 proposal #6059
Closed
V5.10.1 proposal #6059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the hopes of soon having the benchmark code linted, this change groups all the likely non-controversial lint-compliance changes such as indentation, semi-colon usage, and single-vs.-double quotation marks. Other lint rules may have subtle performance implications in the V8 currently shipped with Node.js. Those changes will require more careful review and will be in a separate change. PR-URL: #5429 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Brian White <mscdex@mscdex.net>
There is a benchmark for the class method `Buffer.compare()` but not for the instance method `buf.compare()`. This adds that benchmark. I used this to confirm a performance regression in an implementation I was considering. While the implementation was a bust, it does seem like the benchmark is worthwhile. The benchmark is nearly identical to the existing `Buffer.compare()` benchmark except, of course, that it calls `buf.compare()` instead. PR-URL: #5441 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Evan Lucas <evanlucas@me.com>
Fixes a regression introduced by: #4374. Adds a new test to avoid similar issue in the future. The test is disabled on windows, because this feature never worked there. Fixes: #5398 Reviewed-By: Roman Reiss <me@silverwind.io> Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Evan Lucas <evanlucas@me.com>
Fix several typos. Add missing links. PR-URL: #5230 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Kelvin Knighton <keltheceo@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
On strict mode, "'use strict'; void 0; " is added as prefix in order to prevent "use strict" as the result value for let/const statements. It causes wrong column number in stack trace. PR-URL: #5416 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
`readable.setEncoding(null)` - may be the most preferable way to proxy a binary data without any encoding/decoding overhead PR-URL: #5155 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
TSCP should be TCP PR-URL: #5474 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Fix path.win32.parse("/foo/bar") retuns `{root: '' ...}`(v5.7.0),
but not `{root: '/' ...}`(v5.6.0).
PR-URL: #5484
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Roman Reiss <me@silverwind.io>
Conflicts:
test/parallel/test-path-parse-format.js
The test is still failing sometimes because when trying to establish the second connection, the server is already closed. Bring back the code that handled this case and was removed in the last refactoring of the test. Also ignore the errors that might happen when sending the second handle to the worker because it may already have exited. PR-URL: #5422 Reviewed-By: Rich Trott <rtrott@gmail.com>
As mentioned in the comment of the changed file, "a libuv limitation makes it necessary to bind()". But, that is not the case in this test. The subsequent call to send() results in an implicit bind(). PR-URL: #5023 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Saúl Ibarra Corretgé <saghul@gmail.com>
Reorder slashed protocols so they are grouped by protocol name. This is done so it doesn't look like we're duplicating protocol names at the bottom of the list. PR-URL: #5380 Reviewed-By: Evan Lucas <evanlucas@me.com>
Change types of all PBKDF2 params to `int` as they are `int` in `evp.h`. Check that `raw_keylen` fits into `int` before passing it to OpenSSL. Fix: #5396 PR-URL: #5397 Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp> Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl> Conflicts: test/parallel/test-crypto-pbkdf2.js
Make `HTTPParser` an instance of `AsyncWrap` and make it use `MakeCallback`. This means that async wrap hooks will be called on consumed TCP sockets as well as on non-consumed ones. Additional uses of `AsyncCallbackScope` are necessary to prevent improper state from progressing that triggers failure in the test-http-pipeline-flood.js test. Optimally this wouldn't be necessary, but for the time being it's the most sure way to allow operations to proceed as they have. Fix: #4416 PR-URL: #5419 Reviewed-By: Fedor Indutny <fedor@indutny.com>
PR-URL: #5507 Reviewed-By: Fedor Indutny <fedor@indutny.com>
There is a known issue with SmartOS that is generally worked around in `tools/test.py`. However, a more robust workaround is required for some tests that open many network connections. `test-http-regr-gh-2928` is one such test. Fixes: #5445 Refs: #3941 PR-URL: #5454 Reviewed-By: Fedor Indutny <fedor@indutny.com>
In order to comply with linting rules used in the rest of the code base, eliminate redeclared variables. A conservative approach is used so as to avoid unintentional performance issues (for example, as might be seen in some situations when using `let` instead of `var`). PR-URL: #5468 Reviewed-By: Brian White <mscdex@mscdex.net>
Have `make test` run linting tools before tests rather than after. Lint is likely to find issues quickly. Tests may take a while to run. So do the linting first. Refs: #4546 (comment) PR-URL: #5470 Reviewed-By: Johan Bergström <bugs@bergstroem.nu> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Allow extra options when testing v8 in Node tree PR-URL: #5502 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #5410 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com>
Array#pop() is known to be faster than Array#shift(). To be exact, it's O(1) vs. O(n). In this case there's no difference from which side of the "pool" array the object is retrieved, so .pop() should be preferred. PR-URL: #2174 Reviewed-By: mscdex - Brian White <mscdex@mscdex.net> Reviewed-By: jasnell - James M Snell <jasnell@gmail.com> Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> PR-URL: #5936
`test-stdtout-close-unref.js` will fail if `process.stdin._handle` does
not exist. On UNIX-like operating systems, you can see this failure this
way:
./node test/parallel/test-stdout-close-unref.js < /dev/null
This issue has been experienced by @bengl and @drewfish in a Docker
container. I'm not sure why they are experiencing it in their
environment, but since it is possible that the `_handle` property does
not exist, let's use `child_process.spawn()` to make sure it exists.
PR-URL: #5916
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
IPv6 addresses in Host header (URI), must be enclosed within square brackets, in order to properly separate the host address from any port reference. PR-URL: #5314 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Introduce two new targets we will populate with actions once merged into all branches we need to support through CI. PR-URL: #5921 Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Remove timer to avoid the test timing out occasionally. PR-URL: #5676 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com>
Rather than attempting to keep two versions of docs for timers up to date, keep them in timers.markdown, and leave references to them in globals.markdown. Add setImmediate and clearImmediate to globals.markdown. Change "To schedule" to "Schedules" in timers.markdown. PR-URL: #5837 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
`require-buffer` is only enabled in the `lib` directory. There is no need to disable it in `test`. PR-URL: #6013 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Includes cli.markdown in all.markdown PR-URL: #6011 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
PR-URL: #5986 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use empty string instead of `www.google.com` for tests where we are just doing parameter evaluation. This will avoid DNS lookups which appear to be causing flakiness on Raspberry Pi devices in CI. PR-URL: #5996 Fixes: #5554 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #6029 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Provide encrypted links to freenode IRC. PR-URL: #6019 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Klauke <romaaan.git@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
The test intentionally assigns a global. Use `global` namespace to make it clear that it is intentional and not an accidental leak. PR-URL: #6026 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
The value is retrieved from `process.arch` in node itself. PR-URL: #5997 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
There was a comment in `test-domain-crypto.js` indicating that the pollution of the `global` object with a `domain` property was intentional. Provide more information in the comment so someone may easily determine why. Use `global.domain` rather than declaring `domain` without the `var` keyword to more clearly signal that the pollution is intentional. PR-URL: #6017 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use `global` to be explicit that a global variable is intended. PR-URL: #6014 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Do not convert typed arrays to `Buffer` for deepEqual since their values may not be accurately represented by 8-bit ints. Instead perform binary comparison of underlying `ArrayBuffer`s, but only when the array types match. Never apply any kind of optimization for floating-point typed arrays since bit pattern equality is not the right kind of check for them. PR-URL: #5910 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Fixes: #5907
All JS files have been moved out of the `src` directory so the `.eslintrc` file in that directory can also be removed. PR-URL: #5959 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Roman Klauke <romankl@users.noreply.github.com>
this adds an example of a long running node process that actually executes node code. Also it mentions the not to harmonic detach behaviours of the different platforms, whereas detaching on unix requires ignoring the child_process' stdio explicitely. PR-URL: #5330 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2016-04-05, Version 5.10.1 (Stable), @thealphanerd
Notable changes
http:
path:
Commits
0f5a51ae4b] - assert: Check typed array view type in deepEqual (Anna Henningsen) #5910e966d1f5db] - buffer: don't setkNoZeroFillflag in allocUnsafe (Vladimir Kurchatkin) #60073f75751c2e] - build: introduce ci targets for lint/benchmark (Johan Bergström) #5921781290b61d] - doc: refine child_process detach behaviour (Robert Jefe Lindstaedt) #5330aa9fb03202] - doc: use HTTPS for links where possible (Rich Trott) #6019dd25984838] - doc: note assert.throws() pitfall (Rich Trott) #6029f879f5e68a] - doc: document unspecified behavior for buf.write* methods (James M Snell) #5925f12c3861e0] - doc: clarify stdout/stderr arguments to callback (James M Snell) #6015ce173716be] - doc: add 'Command Line Options' to 'View on single page' (firedfox) #60117337ef6422] - doc: minor argument formatting in stream.markdown (James M Snell) #60160ae5d027c6] - doc: clarify that __dirname is module local (James M Snell) #60188bec8aa41f] - doc: consolidate timers docs in timers.markdown (Bryan English) #58370a13099c42] - etw: add event messages (João Reis) #5936c6ac6f2ea1] - http: Corrects IPv6 address in Host header (Mihai Potra) #53148317778925] - meta: add "joining a wg" section to WORKING_GROUPS.md (Matteo Collina) #5488f3f19ee5e2] - net: refactor self=this to arrow functions (Benjamin Gruenbaum) #58571c4007927d] - path: fix win32.isAbsolute() inconsistency (Brian White) #6028059b607a4f] - test: make use of globals explicit (Rich Trott) #6014cc8fcc5a07] - test: be explicit about polluting ofglobal(Rich Trott) #60177db7a820b9] - test: make arch available in status files (Santiago Gimeno) #599702f2ebd9b4] - test: explicitly set global in test-repl (Rich Trott) #60262ab1237137] - test: fix flaky test-net-socket-timeout-unref (Rich Trott) #60030127c2bd39] - test: fix test-dns.js flakiness (Rich Trott) #59966052ced37f] - test: fix error message checks in test-module-loading (James M Snell) #5986a40b0cb673] - test: refactor http-end-throw-socket-handling (Santiago Gimeno) #567696bb315262] - test: ensure _handle property existence (Rich Trott) #59164f1fa2adeb] - test: fix offending max-len linter error (Sakthipriyan Vairamani) #5980f14d71ccea] - test: stdin is not always a net.Socket (Jeremiah Senkpiel) #593550a062e691] - tools: remove obsolete lint config file (Rich Trott) #59597491fdcfe9] - tools: remove disabling of already-disabled rule (Rich Trott) #6013