stream: add diagnostics for readable stream chunk additions#60514
Closed
RaisinTen wants to merge 1 commit intonodejs:mainfrom
Closed
stream: add diagnostics for readable stream chunk additions#60514RaisinTen wants to merge 1 commit intonodejs:mainfrom
RaisinTen wants to merge 1 commit intonodejs:mainfrom
Conversation
Signed-off-by: Darshan Sen <raisinten@gmail.com>
Collaborator
|
Review requested:
|
ronag
requested changes
Oct 31, 2025
Member
ronag
left a comment
There was a problem hiding this comment.
I don't think this is necessary.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60514 +/- ##
==========================================
+ Coverage 88.56% 88.58% +0.01%
==========================================
Files 704 704
Lines 207774 207868 +94
Branches 40027 40052 +25
==========================================
+ Hits 184020 184138 +118
+ Misses 15800 15766 -34
- Partials 7954 7964 +10
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a diagnostics channel for tracking chunk additions to readable streams without having any side-effects on user code.
This is needed for #60483 (comment)