repl: tab completion targets <class> instead of new <class>

[hainenber]

Summary

Fixes #60306

I've modified the function findExpressionCompleteTarget to handle autocompletion for new <class> code by detecting proper identifiers and re-parse only for <class> identifier instead.

Testing

• New test added: test/parallel/test-repl-tab-complete-new-expression.js
• Visual confirmation with expected correct behavior in linked issue

[hainenber]

hi @Renegade334, sorry for pinging but can you help review this one? I hope everything's up to par with expected quality for a nodejs/node pull request

[Renegade334]

Is this check necessary? It excludes MemberExpressions (the same logic should apply to new X.Y. as applies to new X.).

[hainenber]

Thanks for the review! I've loosened the condition to only null check the expression.callee properties. This should handle case of new X.Y..

Please take a look when you have time.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70035/

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.53%. Comparing base (e105e82) to head (3549c25).
⚠️ Report is 336 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff            @@
##             main   #60319    +/-   ##
========================================
  Coverage   88.53%   88.53%            
========================================
  Files         704      703     -1     
  Lines      208087   208270   +183     
  Branches    40006    40158   +152     
========================================
+ Hits       184223   184391   +168     
- Misses      15869    15885    +16     
+ Partials     7995     7994     -1     

Files with missing lines	Coverage Δ
lib/internal/repl/completion.js	94.82% <100.00%> (+0.06%)	⬆️

... and 206 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[Renegade334]

CI is complaining that you have a double-space in your first commit message, can you please amend this?

[hainenber]

CI is complaining that you have a double-space in your first commit message, can you please amend this?

I've fixed in the HEAD commit. Apologies for the force push, I had to rebase and pick reword.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/70261/

[nodejs-github-bot]

Landed in d729bec