src: avoid unnecessary string -> char* -> string round trips#60055
Closed
addaleax wants to merge 1 commit intonodejs:mainfrom
Closed
src: avoid unnecessary string -> char* -> string round trips#60055addaleax wants to merge 1 commit intonodejs:mainfrom
char* -> string round trips#60055addaleax wants to merge 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
In these places we can just generate `std::string` directly, so there's no need to convert to an intermediate C string.
addaleax
force-pushed
the
to-string-direct-not-via-cstr
branch
from
132bc95 to
327d5d3
Compare
jasnell
approved these changes
Sep 28, 2025
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #60055 +/- ##
==========================================
+ Coverage 88.45% 88.47% +0.01%
==========================================
Files 703 703
Lines 207546 207544 -2
Branches 40011 40004 -7
==========================================
+ Hits 183591 183619 +28
+ Misses 15949 15904 -45
- Partials 8006 8021 +15
🚀 New features to boost your workflow:
|
addaleax
added
author ready
github-actions
bot
removed
the
request-ci
Collaborator
lpinca
approved these changes
Sep 29, 2025
legendecas
approved these changes
Sep 29, 2025
addaleax
added a commit
that referenced
this pull request
Sep 30, 2025
In these places we can just generate `std::string` directly, so there's no need to convert to an intermediate C string. PR-URL: #60055 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Member
Author
|
Landed in 77cf2ef |
targos
pushed a commit
that referenced
this pull request
Oct 6, 2025
In these places we can just generate `std::string` directly, so there's no need to convert to an intermediate C string. PR-URL: #60055 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Oct 22, 2025
In these places we can just generate `std::string` directly, so there's no need to convert to an intermediate C string. PR-URL: #60055 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In these places we can just generate
std::stringdirectly, so there's no need to convert to an intermediate C string.