Skip to content

[v22.x] src: track BaseObjects with an efficient list #59959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[v22.x] src: track BaseObjects with an efficient list #59959

wants to merge 1 commit into from
+85 −85

Conversation

legendecas
Copy link
Member

PR-URL: #55104
Refs: #54880
Reviewed-By: Matteo Collina matteo.collina@gmail.com
Reviewed-By: Joyee Cheung joyeec9h3@gmail.com

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/realm
  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch. labels Sep 21, 2025
@richardlau
Copy link
Member

The modified test/pummel/test-heapdump-env.js test appears to be failing.

@legendecas
src: track BaseObjects with an efficient list
8b3a537 
PR-URL: nodejs#55104
Refs: nodejs#54880
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 21, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69316/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/69324/

richardlau pushed a commit that referenced this pull request Sep 22, 2025
@legendecas @richardlau
src: track BaseObjects with an efficient list
937e9bb 
PR-URL: #55104
Backport-PR-URL: #59959
Refs: #54880
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@richardlau
Copy link
Member

Landed in 937e9bb

@richardlau richardlau closed this Sep 22, 2025
@legendecas legendecas deleted the backport-55104-to-22 branch September 23, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richardlau richardlau richardlau approved these changes

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v22.x Issues that can be reproduced on v22.x or PRs targeting the v22.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@legendecas @nodejs-github-bot @richardlau