doc: remove fast fallback information from v8 fast api contribution guidelines #59951
+29
−75
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
Renegade334
reviewed
Sep 20, 2025
Comment on lines
+14
to
+15
| * Throwing errors is not available from within a fast API call. If you need to | ||
| throw, perform validation in JavaScript or only expose a slow API. |
There was a problem hiding this comment.
This isn't actually accurate either – it's possible to throw errors within fast API calls, as the API now provides access to the isolate.
I did try to include this under some wider proposed changes at #58999, although that never garnered much comment. If this PR does go through separately, then this wording will need updating.
There was a problem hiding this comment.
Yeah let's do your PR @Renegade334
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reading the Fast API guidelines, seeing the fallback section made me have an incorrect understanding of the API, because
fallbackno longer exists inFastApiCallbackOptions.I believe this functionality was removed, so this PR updates the guidelines accordingly.