fs,win: do not add a second trailing slash in readdir

[Flarna]

Do not add a trailing slash if it was not removed by resolve in ToNamespacedPath.

Unfortunatelly I do not know how to test this without 3rd party tools descirbed in #58223.

Refs: #56110
Fixes: #58223

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.27%. Comparing base (861d624) to head (f8fd082).
⚠️ Report is 218 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #59847      +/-   ##
==========================================
+ Coverage   88.26%   88.27%   +0.01%     
==========================================
  Files         701      701              
  Lines      206774   206774              
  Branches    39778    39779       +1     
==========================================
+ Hits       182514   182540      +26     
+ Misses      16298    16236      -62     
- Partials     7962     7998      +36     

Files with missing lines	Coverage Δ
src/node_file.cc	75.63% <ø> (ø)

... and 44 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/69260/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/59847
✔  Done loading data for nodejs/node/pull/59847
----------------------------------- PR info ------------------------------------
Title      fs,win: do not add a second trailing slash in readdir (#59847)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     Flarna:win-readdir -> nodejs:main
Labels     c++, fs, windows, author ready, needs-ci, review wanted, dont-land-on-v20.x
Commits    1
 - fs,win: do not add a second trailing slash in readdir
Committers 1
 - Gerhard Stöbich <18708370+Flarna@users.noreply.github.com>
PR-URL: https://github.com/nodejs/node/pull/59847
Fixes: https://github.com/nodejs/node/issues/58223
Refs: https://github.com/nodejs/node/pull/56110
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/59847
Fixes: https://github.com/nodejs/node/issues/58223
Refs: https://github.com/nodejs/node/pull/56110
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
--------------------------------------------------------------------------------
   ℹ  This PR was created on Wed, 10 Sep 2025 21:15:10 GMT
   ✔  Approvals: 1
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/59847#pullrequestreview-3231494342
   ✘  This PR needs to wait 23 more hours to land (or 0 hours if there is one more approval)
   ✔  Last GitHub CI successful
   ℹ  Last Full PR CI on 2025-09-16T20:00:43Z: https://ci.nodejs.org/job/node-test-pull-request/69260/
- Querying data for job/node-test-pull-request/69260/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/17779373274

[nodejs-github-bot]

Landed in f6ea5bf

[felipecrs]

Thanks a lot!

Do I need to request or will this be automatically cherry-picked to 22.x and 24.x?

[targos]

It will be automatically cherry-picked to 24.x, and for 22.x, the lts-watch-v22.x label is the request.

[richardlau]

FYI the release process is that changes normally have to be in a current release (i.e. Node.js 24.x) for two weeks before being considered for inclusion in a Long Term Support (e.g. Node.js 22.x) release.

[felipecrs]

Understood. I'm using Electron, so it will naturally take much longer to arrive there anyway.

[felipecrs]

@richardlau v24.9.0 included it and it is now around 2 weeks old.

Do you think it's time to consider backporting it to 22.x?