Skip to content

[v20.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58961

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

[v20.x backport] crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4 #58961

wants to merge 2 commits into from

Conversation

@panva
Copy link
Member

@panva panva commented Jul 5, 2025

Backports #58942 to v20.x

aduh95 and others added 2 commits June 23, 2025 12:20
@aduh95
tools: disable failing coverage jobs
1b8f5da 
PR-URL: nodejs#58770
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@panva
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
ca8d3a7 
Reverts: nodejs#56160
Fixes: nodejs#56159
Fixes: nodejs#58913
Refs: nodejs#58121
PR-URL: nodejs#58942
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

Review requested:

  • @nodejs/crypto

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch. labels Jul 5, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67849/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67850/

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Jul 5, 2025

CI: https://ci.nodejs.org/job/node-test-pull-request/67852/

Hardanish-Singh
Hardanish-Singh reviewed Jul 5, 2025
View reviewed changes
Copy link

@Hardanish-Singh Hardanish-Singh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@panva panva mentioned this pull request Aug 1, 2025
Closed
marco-ippolito pushed a commit that referenced this pull request Aug 14, 2025
@panva @marco-ippolito
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
89366ab 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@marco-ippolito
Copy link
Member

marco-ippolito commented Aug 14, 2025

Landed in 89366ab

@panva panva deleted the backport-58942-to-20 branch August 14, 2025 10:44
marco-ippolito pushed a commit that referenced this pull request Aug 25, 2025
@panva @marco-ippolito
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
fa6b798 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@panva panva mentioned this pull request Aug 27, 2025
Merged
@panva panva restored the backport-58942-to-20 branch August 27, 2025 07:20
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@panva @marco-ippolito
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
090c2a6 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
@panva panva deleted the backport-58942-to-20 branch August 27, 2025 14:43
marco-ippolito pushed a commit that referenced this pull request Aug 27, 2025
@panva @marco-ippolito
crypto: fix SHAKE128/256 breaking change introduced with OpenSSL 3.4
068c439 
Reverts: #56160
Fixes: #56159
Fixes: #58913
Refs: #58121
PR-URL: #58942
Backport-PR-URL: #58961
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marco-ippolito marco-ippolito marco-ippolito approved these changes

+1 more reviewer

@Hardanish-Singh Hardanish-Singh Hardanish-Singh left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. crypto Issues and PRs related to the crypto subsystem. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. v20.x Issues that can be reproduced on v20.x or PRs targeting the v20.x-staging branch.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@panva @nodejs-github-bot @marco-ippolito @Hardanish-Singh @aduh95