Skip to content

worker: add worker name to report #58935

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

worker: add worker name to report #58935

wants to merge 1 commit into from
+8 −5

Conversation

theanarkh
Copy link
Contributor

Add worker name to report.

  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. worker Issues and PRs related to Worker support. labels Jul 2, 2025
@theanarkh theanarkh force-pushed the add_worker_name_to_report branch 2 times, most recently from ca2fa61 to 9ec7bae Compare July 2, 2025 17:53
@codecov Codecov
Copy link

codecov bot commented Jul 2, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 90.05%. Comparing base (ba8fbf3) to head (15e172c).
Report is 1032 commits behind head on main.

Files with missing lines Patch % Lines
src/node_report.cc 0.00% 2 Missing ⚠️
src/node_worker.h 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58935      +/-   ##
==========================================
- Coverage   90.37%   90.05%   -0.32%     
==========================================
  Files         629      645      +16     
  Lines      184373   189131    +4758     
  Branches    36022    37092    +1070     
==========================================
+ Hits       166624   170320    +3696     
- Misses      10906    11534     +628     
- Partials     6843     7277     +434
Files with missing lines Coverage Δ
src/node_worker.h 83.33% <0.00%> (-7.58%) ⬇️
src/node_report.cc 91.07% <0.00%> (-2.16%) ⬇️

... and 339 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@legendecas legendecas added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67835/

@legendecas legendecas added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 4, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67855/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67859/

@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 7, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67873/

@legendecas
Copy link
Member

CI failure on windows is relevant: https://ci.nodejs.org/job/node-test-binary-windows-js-suites/35288/

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jul 11, 2025
@theanarkh theanarkh force-pushed the add_worker_name_to_report branch from 9ec7bae to 15e172c Compare July 13, 2025 07:56
@theanarkh theanarkh added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 13, 2025
@theanarkh theanarkh added request-ci Add this label to start a Jenkins CI on a PR. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

@StefanStojanovic StefanStojanovic StefanStojanovic approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. report Issues and PRs related to process.report. request-ci Add this label to start a Jenkins CI on a PR. worker Issues and PRs related to Worker support.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@theanarkh @nodejs-github-bot @legendecas @jasnell @addaleax @lpinca @StefanStojanovic @aduh95