Skip to content

src,permission: enhance permission model debug #58898

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2025
Merged

src,permission: enhance permission model debug #58898

merged 1 commit into from
Jul 2, 2025
+41 −31

Conversation

RafaelGSS
Copy link
Member

src,permission: enhance permission model debug

This commit enhances the permission model debug logs when NODE_DEBUG_NATIVE=PERMISSION_MODEL is used

Example

Inserting /Users/rafaelgss/repos/os/node/t.js
└─ /
   ├─ Users/rafaelgss/repos/os/node/t.js
   └─ tm
      ├─ 3
      ├─ 2
      └─ p/*

@RafaelGSS RafaelGSS added the permission Issues and PRs related to the Permission Model label Jun 30, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/security-wg

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 28 lines in your changes missing coverage. Please review.

Project coverage is 90.10%. Comparing base (d08513d) to head (71b8b70).
Report is 51 commits behind head on main.

Files with missing lines Patch % Lines
src/permission/fs_permission.cc 0.00% 28 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58898      +/-   ##
==========================================
- Coverage   90.11%   90.10%   -0.02%     
==========================================
  Files         640      640              
  Lines      188363   188438      +75     
  Branches    36931    36954      +23     
==========================================
+ Hits       169739   169783      +44     
- Misses      11341    11367      +26     
- Partials     7283     7288       +5
Files with missing lines Coverage Δ
src/permission/fs_permission.cc 68.11% <0.00%> (-6.69%) ⬇️

... and 67 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

jasnell
jasnell reviewed Jun 30, 2025
View reviewed changes
@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 30, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67746/

@RafaelGSS
src,permission: enhance permission model debug
71b8b70 
This commit enhance the permission model debug logs
when NODE_DEBUG_NATIVE=PERMISSION_MODEL is used

Example

Inserting /Users/rafaelgss/repos/os/node/t.js
└─ /
   ├─ Users/rafaelgss/repos/os/node/t.js
   └─ tm
      ├─ 3
      ├─ 2
      └─ p/*

Signed-off-by: RafaelGSS <rafael.nunu@hotmail.com>
@RafaelGSS RafaelGSS force-pushed the improve-permission-model-debugger branch from a1f1b06 to 71b8b70 Compare June 30, 2025 21:17
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67763/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67769/

@RafaelGSS RafaelGSS added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. review wanted PRs that need reviews. labels Jul 1, 2025
@RafaelGSS RafaelGSS added commit-queue Add this label to land a pull request using GitHub Actions. and removed review wanted PRs that need reviews. labels Jul 2, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jul 2, 2025
@nodejs-github-bot nodejs-github-bot merged commit 46508d9 into nodejs:main Jul 2, 2025
64 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 46508d9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. permission Issues and PRs related to the Permission Model
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RafaelGSS @nodejs-github-bot @jasnell @marco-ippolito