Skip to content

fs: avoid computing time coefficient constants in runtime #58728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

LiviaMedeiros
Copy link
Member

Fixes: #58726 1

These constants can be precomputed.

Footnotes

  1. even though it's not a Node.js bug

@nodejs-github-bot nodejs-github-bot added fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run. labels Jun 16, 2025
Copy link

codecov bot commented Jun 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (d6dade5) to head (12f5b70).
Report is 9 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #58728   +/-   ##
=======================================
  Coverage   90.12%   90.13%           
=======================================
  Files         637      637           
  Lines      188121   188121           
  Branches    36892    36891    -1     
=======================================
+ Hits       169552   169557    +5     
+ Misses      11313    11311    -2     
+ Partials     7256     7253    -3     
Files with missing lines Coverage Δ
lib/internal/fs/utils.js 99.69% <100.00%> (ø)

... and 25 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 16, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 16, 2025
@nodejs-github-bot
Copy link
Collaborator

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 17, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 18, 2025
@nodejs-github-bot nodejs-github-bot merged commit f2e99c5 into nodejs:main Jun 18, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in f2e99c5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fs Issues and PRs related to the fs subsystem / file system. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fs: non-bigint stat can give 0.20566138856% bigger results
6 participants