Skip to content

src: enhance error messages for unknown options #58677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 13, 2025
Merged

src: enhance error messages for unknown options #58677

merged 1 commit into from
Jun 13, 2025

Conversation

pmarchini
Copy link
Member

Before this PR, the error was being printed in a malformed way, containing part of the JSON content

Screenshot 2025-06-11 at 15 18 05

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/config

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run. labels Jun 11, 2025
@pmarchini pmarchini requested a review from marco-ippolito June 11, 2025 13:25
@marco-ippolito marco-ippolito added request-ci Add this label to start a Jenkins CI on a PR. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. labels Jun 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 11, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67408/

@codecov Codecov
Copy link

codecov bot commented Jun 11, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.17%. Comparing base (58e1cba) to head (2ebab36).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58677   +/-   ##
=======================================
  Coverage   90.17%   90.17%           
=======================================
  Files         636      636           
  Lines      188028   188060   +32     
  Branches    36895    36903    +8     
=======================================
+ Hits       169547   169576   +29     
- Misses      11233    11236    +3     
  Partials     7248     7248
Files with missing lines Coverage Δ
src/node_config_file.cc 79.44% <ø> (-0.12%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67413/

@pmarchini pmarchini added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@pmarchini pmarchini added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 13, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 13, 2025
@nodejs-github-bot nodejs-github-bot merged commit 3ac0e28 into nodejs:main Jun 13, 2025
81 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 3ac0e28

targos pushed a commit that referenced this pull request Jun 16, 2025
@pmarchini @targos
src: enhance error messages for unknown options
dfb0144 
PR-URL: #58677
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@lpinca lpinca lpinca approved these changes

@marco-ippolito marco-ippolito marco-ippolito approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. config Issues or PRs related to the config subsystem needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@pmarchini @nodejs-github-bot @jasnell @addaleax @lpinca @marco-ippolito @RaisinTen