Skip to content

test: cleanup status files #58633

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2025
Merged

test: cleanup status files #58633

merged 1 commit into from
Jun 10, 2025
+2 −6

Conversation

panva
Copy link
Member

@panva panva commented Jun 8, 2025

  • removes empty expectations from status files
  • aligns empty status file to be single-line json

@panva panva added test Issues and PRs related to the tests. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/web-standards

@nodejs-github-bot nodejs-github-bot added the needs-ci PRs that need a full CI run. label Jun 8, 2025
@github-actions github-actions bot added request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@github-actions GitHub Actions

This comment was marked as outdated.

Sign in to view
@panva panva removed the request-ci-failed An error occurred while starting CI via request-ci label, and manual interventon is needed. label Jun 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67327/

@codecov Codecov
Copy link

codecov bot commented Jun 8, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.13%. Comparing base (3c351c2) to head (65de22a).
Report is 18 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #58633   +/-   ##
=======================================
  Coverage   90.13%   90.13%           
=======================================
  Files         636      636           
  Lines      187891   187891           
  Branches    36878    36878           
=======================================
+ Hits       169348   169363   +15     
- Misses      11289    11294    +5     
+ Partials     7254     7234   -20

see 41 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67329/

@panva panva added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jun 9, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 10, 2025
@nodejs-github-bot nodejs-github-bot merged commit d0b6194 into nodejs:main Jun 10, 2025
73 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in d0b6194

@panva panva deleted the wpt-clean-status branch June 10, 2025 14:01
seriousme pushed a commit to seriousme/node that referenced this pull request Jun 10, 2025
@panva @seriousme
test: cleanup status files
a2e7476 
PR-URL: nodejs#58633
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
targos pushed a commit that referenced this pull request Jun 16, 2025
@panva @targos
test: cleanup status files
181014a 
PR-URL: #58633
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Jason Zhang <xzha4350@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@legendecas legendecas legendecas approved these changes

@jazelly jazelly jazelly approved these changes

@KhafraDev KhafraDev KhafraDev approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@panva @nodejs-github-bot @lpinca @legendecas @jazelly @KhafraDev