-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
test: skip tests failing when run under root #58610
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: skip tests failing when run under root #58610
Conversation
Review requested:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58610 +/- ##
==========================================
- Coverage 90.20% 90.16% -0.05%
==========================================
Files 636 636
Lines 187698 188030 +332
Branches 36852 36899 +47
==========================================
+ Hits 169316 169529 +213
- Misses 11165 11271 +106
- Partials 7217 7230 +13 🚀 New features to boost your workflow:
|
out of curiosity, what does that |
root is superuser, with UID === 0. |
This comment was marked as outdated.
This comment was marked as outdated.
Thank you, @LiviaMedeiros |
Windows failures are related
|
Landed in be2120f |
PR-URL: nodejs#58610 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
PR-URL: #58610 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Pietro Marchini <pietro.marchini94@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com>
No description provided.