-
-
Notifications
You must be signed in to change notification settings - Fork 32.2k
doc: add path rules and validation for export targets in package.json #58604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Review requested:
|
algoORgoal
reviewed
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This commit describes what was missing perfectly. Thank you for your pull request :)
JakobJingleheimer
approved these changes
Jun 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
JakobJingleheimer
approved these changes
Jun 7, 2025
marco-ippolito
approved these changes
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
reviewed
Jun 7, 2025
aduh95
approved these changes
Jun 9, 2025
Landed in 987aa0a |
seriousme
pushed a commit
to seriousme/node
that referenced
this pull request
Jun 10, 2025
PR-URL: nodejs#58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58604 Reviewed-By: Jacob Smith <jacob@frende.me> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
This was referenced Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
commit-queue-squash
Add this label to instruct the Commit Queue to squash all the PR commits into the first one.
doc
Issues and PRs related to the documentations.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Close #58576
I have added a new section called
# Path Rules and Validation for Export Targets
that goes over the invalid paths that are possible & and their valid counter parts