Skip to content

build: remove config.status under make distclean #58603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 12, 2025
Merged

build: remove config.status under make distclean #58603

merged 1 commit into from
Jun 12, 2025
+1 −1

Conversation

Renegade334
Copy link
Contributor

refs: #21371

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Jun 6, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 6, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.69%. Comparing base (c1f090d) to head (d437db6).
Report is 52 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #58603      +/-   ##
==========================================
- Coverage   90.20%   89.69%   -0.51%     
==========================================
  Files         636      636              
  Lines      187698   187698              
  Branches    36852    36564     -288     
==========================================
- Hits       169316   168362     -954     
- Misses      11165    12054     +889     
- Partials     7217     7282      +65

see 95 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Renegade334 Renegade334 changed the title tools: remove config.status under make distclean build: remove config.status under make distclean Jun 6, 2025
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Jun 8, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jun 8, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67343/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/67424/

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jun 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 88cfdb3 into nodejs:main Jun 12, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 88cfdb3

targos pushed a commit that referenced this pull request Jun 16, 2025
@Renegade334 @targos
tools: remove config.status under make distclean
268c8c1 
PR-URL: #58603
Refs: #21371
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request Jun 16, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Renegade334 @nodejs-github-bot @lpinca @aduh95