test: update WPT for urlpattern to 3ffda23e5a #58537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review requested:
|
jasnell
approved these changes
Jun 1, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58537 +/- ##
==========================================
- Coverage 90.23% 90.14% -0.09%
==========================================
Files 635 636 +1
Lines 187580 188028 +448
Branches 36860 36889 +29
==========================================
+ Hits 169265 169506 +241
- Misses 11101 11280 +179
- Partials 7214 7242 +28 🚀 New features to boost your workflow:
|
bjohansebas
approved these changes
Jun 1, 2025
|
Tentative tests shouldn't run since they are experimental. We should avoid running all of those things. |
|
Running tentative tests is still valuable if the spec is set in stone but WPTs not yet updated to reflect non-tentativeness. If you don't wish to run these particular ones individually skip them or acknowledge their failure. |
panva
added
request-ci
panva
approved these changes
Jun 10, 2025
Ethan-Arrowood
approved these changes
Jun 10, 2025
github-actions
bot
removed
the
request-ci
panva
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/58537 ✔ Done loading data for nodejs/node/pull/58537 ----------------------------------- PR info ------------------------------------ Title test: update WPT for urlpattern to 3ffda23e5a (#58537) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/update-urlpattern-wpt -> nodejs:main Labels test, needs-ci Commits 2 - test: update WPT for urlpattern to 3ffda23e5a - fixup! test: update WPT for urlpattern to 3ffda23e5a Committers 2 - Node.js GitHub Bot <github-bot@iojs.org> - Filip Skokan <panva.ip@gmail.com> PR-URL: https://github.com/nodejs/node/pull/58537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/58537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev> -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 01 Jun 2025 00:24:00 GMT ✔ Approvals: 3 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/58537#pullrequestreview-2884856289 ✔ - Filip Skokan (@panva) (TSC): https://github.com/nodejs/node/pull/58537#pullrequestreview-2913584556 ✔ - Ethan Arrowood (@Ethan-Arrowood): https://github.com/nodejs/node/pull/58537#pullrequestreview-2913642970 ✘ Last GitHub CI failed ℹ Last Full PR CI on 2025-06-10T19:19:18Z: https://ci.nodejs.org/job/node-test-pull-request/67391/ - Querying data for job/node-test-pull-request/67391/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/15581852088 |
panva
pushed a commit
that referenced
this pull request
Jun 11, 2025
PR-URL: #58537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
|
Landed in e027da9 |
targos
pushed a commit
that referenced
this pull request
Jun 16, 2025
PR-URL: #58537 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Filip Skokan <panva.ip@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated update of the WPT for urlpattern to web-platform-tests/wpt@3ffda23.