Skip to content

Conversation

@anonrig
Copy link
Member

@anonrig anonrig commented May 31, 2025

Since runtime deprecating this, it has been 13 major versions...

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. labels May 31, 2025
@anonrig anonrig force-pushed the yagiz/eol-dgram branch from b12f3c9 to 9e2c782 Compare May 31, 2025 00:17
@anonrig anonrig added semver-major PRs that contain breaking changes and should be released in the next major version. deprecations Issues and PRs related to deprecations. labels May 31, 2025
@anonrig anonrig force-pushed the yagiz/eol-dgram branch from 9e2c782 to 4fb3225 Compare May 31, 2025 00:19
@jasnell
Copy link
Member

jasnell commented May 31, 2025

Duplicate ;-) #58474

@anonrig
Copy link
Member Author

anonrig commented May 31, 2025

Dammit.

@anonrig anonrig closed this May 31, 2025
@anonrig anonrig deleted the yagiz/eol-dgram branch May 31, 2025 00:20
@anonrig
Copy link
Member Author

anonrig commented May 31, 2025

Duplicate ;-) #58474

What's funny is that, I approved that PR...

@codecov
Copy link

codecov bot commented May 31, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.23%. Comparing base (9524908) to head (4fb3225).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #58520      +/-   ##
==========================================
- Coverage   90.25%   90.23%   -0.03%     
==========================================
  Files         635      635              
  Lines      187635   187564      -71     
  Branches    36861    36853       -8     
==========================================
- Hits       169347   169243     -104     
- Misses      11055    11099      +44     
+ Partials     7233     7222      -11     
Files with missing lines Coverage Δ
lib/dgram.js 97.45% <100.00%> (-0.17%) ⬇️

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deprecations Issues and PRs related to deprecations. dgram Issues and PRs related to the dgram subsystem / UDP. needs-ci PRs that need a full CI run. semver-major PRs that contain breaking changes and should be released in the next major version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants