Skip to content

tools: support DisposableStack and AsyncDisposableStack in linter #58454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LiviaMedeiros merged 1 commit into from
May 27, 2025
Merged

tools: support DisposableStack and AsyncDisposableStack in linter #58454

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions eslint.config.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,6 +120,7 @@ export default [
{
languageOptions: {
globals: {
AsyncDisposableStack: 'readonly',
ByteLengthQueuingStrategy: 'readonly',
CompressionStream: 'readonly',
CountQueuingStrategy: 'readonly',
Expand All @@ -128,6 +129,7 @@ export default [
Crypto: 'readonly',
CryptoKey: 'readonly',
DecompressionStream: 'readonly',
DisposableStack: 'readonly',
EventSource: 'readable',
fetch: 'readonly',
Float16Array: 'readonly',
Expand Down
13 changes: 12 additions & 1 deletion lib/eslint.config_partial.mjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -356,11 +356,22 @@ export default [
name: 'SubtleCrypto',
message: "Use `const { SubtleCrypto } = require('internal/crypto/webcrypto');` instead of the global.",
},
// Float16Array is not available in primordials because it's only available with --js-float16array CLI flag.
// Float16Array is not available in primordials because it can be
// disabled with --no-js-float16array CLI flag.
{
name: 'Float16Array',
message: 'Use `const { Float16Array } = globalThis;` instead of the global.',
},
// DisposableStack and AsyncDisposableStack are not available in primordials because they can be
// disabled with --no-js-explicit-resource-management CLI flag.
{
name: 'DisposableStack',
message: 'Use `const { DisposableStack } = globalThis;` instead of the global.',
},
{
name: 'AsyncDisposableStack',
message: 'Use `const { AsyncDisposableStack } = globalThis;` instead of the global.',
},
],
'no-restricted-modules': [
'error',
Expand Down
Loading