Skip to content

os: rename functions wrapped via hideStackFrames() #58159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

os: rename functions wrapped via hideStackFrames() #58159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a5a66c1
os: rename functions wrapped via `hideStackFrames()`
LiviaMedeiros May 4, 2025
d1f1996
squash: use `assignFunctionName()`
LiviaMedeiros May 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 11 additions & 8 deletions lib/os.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,10 @@ const {
},
hideStackFrames,
} = require('internal/errors');
const { getCIDR } = require('internal/util');
const {
assignFunctionName,
getCIDR,
} = require('internal/util');
const { validateInt32 } = require('internal/validators');

const {
Expand All @@ -59,15 +62,15 @@ const {
setPriority: _setPriority,
} = internalBinding('os');

function getCheckedFunction(fn) {
return hideStackFrames(function checkError() {
function getCheckedFunction(fn, name) {
return assignFunctionName(name, hideStackFrames(function checkError() {
const ctx = {};
const ret = fn(ctx);
if (ret === undefined) {
throw new ERR_SYSTEM_ERROR.HideStackFramesError(ctx);
}
return ret;
});
}));
}

const {
Expand All @@ -77,10 +80,10 @@ const {
3: machine,
} = _getOSInformation();

const getHomeDirectory = getCheckedFunction(_getHomeDirectory);
const getHostname = getCheckedFunction(_getHostname);
const getInterfaceAddresses = getCheckedFunction(_getInterfaceAddresses);
const getUptime = getCheckedFunction(_getUptime);
const getHomeDirectory = getCheckedFunction(_getHomeDirectory, 'getHomeDirectory');
Copy link
Member

@anonrig anonrig May 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we run benchmarks on these changes?

const getHostname = getCheckedFunction(_getHostname, 'getHostname');
const getInterfaceAddresses = getCheckedFunction(_getInterfaceAddresses, 'getInterfaceAddresses');
const getUptime = getCheckedFunction(_getUptime, 'getUptime');

/**
* @returns {string}
Expand Down
Loading