os: rename functions wrapped via hideStackFrames()
#58159
+11
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
anonrig
requested changes
May 4, 2025
| const getHostname = getCheckedFunction(_getHostname); | ||
| const getInterfaceAddresses = getCheckedFunction(_getInterfaceAddresses); | ||
| const getUptime = getCheckedFunction(_getUptime); | ||
| const getHomeDirectory = getCheckedFunction(_getHomeDirectory, 'getHomeDirectory'); |
There was a problem hiding this comment.
Can we run benchmarks on these changes?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #58159 +/- ##
==========================================
- Coverage 90.17% 90.17% -0.01%
==========================================
Files 630 630
Lines 186503 186506 +3
Branches 36618 36615 -3
==========================================
- Hits 168188 168179 -9
- Misses 11120 11125 +5
- Partials 7195 7202 +7
🚀 New features to boost your workflow:
|
jasnell
approved these changes
May 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The internal
hideStackFrames()returns wrapper function with.name === 'wrappedFn'(and.length === 0which aligns with desired value), and these wrappers are exported directly to userspace. Let's give them more meaningful names.