async_hooks: enable AsyncLocalStorage once constructed

[legendecas]

This fixes the leak behavior when using enterWith when no
AsyncLocalStorages were enabled inside a promise. With this
change, the following code snippets will behave the same:

import { AsyncLocalStorage } from 'node:async_hooks';

const als = new AsyncLocalStorage();

async function main () {
  await 1
  als.enterWith('internal');
}

await main()

console.log(als.getStore() ?? 'default');

import { AsyncLocalStorage } from 'node:async_hooks';

const als = new AsyncLocalStorage();
als.enterWith(undefined); // Forcefully enable the AsyncLocalStorage.

async function main () {
  await 1
  als.enterWith('internal');
}

await main()

console.log(als.getStore() ?? 'default');

On the performance side, given that an AsyncLocalStorage is constructed, we should assume that it will be used and prefer correctness over lazy-initialization optimization.

Fixes: #53037
Refs: #58019

/cc @nodejs/diagnostics

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (25fe802) to head (0ee37f3).
Report is 18 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #58029      +/-   ##
==========================================
- Coverage   90.27%   90.27%   -0.01%     
==========================================
  Files         630      630              
  Lines      186159   186161       +2     
  Branches    36473    36476       +3     
==========================================
- Hits       168053   168048       -5     
+ Misses      10976    10974       -2     
- Partials     7130     7139       +9     

Files with missing lines	Coverage Δ
lib/internal/async_local_storage/async_hooks.js	97.95% <100.00%> (+0.02%)	⬆️

... and 19 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66467/

[mcollina]

lgtm

[Qard]

Does this only reproduce with the async_hooks version of AsyncLocalStorage?

[legendecas]

Does this only reproduce with the async_hooks version of AsyncLocalStorage?

Yes.

[nodejs-github-bot]

Landed in 8e7ae60

[mcollina]

I'm adding a backing-for-lts comment as we should evaluate if it has real-life breakage before backporting