doc: add returns for https.get #58025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com>
nodejs-github-bot
added
doc
anonrig
approved these changes
Apr 25, 2025
lpinca
approved these changes
Apr 25, 2025
bjohansebas
approved these changes
Apr 26, 2025
jasnell
approved these changes
Apr 26, 2025
trivikr
approved these changes
Apr 27, 2025
anonrig
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 397802e |
RafaelGSS
pushed a commit
that referenced
this pull request
May 1, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 2, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 6, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
RafaelGSS
pushed a commit
that referenced
this pull request
May 14, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 16, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 17, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 18, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
May 19, 2025
Signed-off-by: Eng Zer Jun <engzerjun@gmail.com> PR-URL: #58025 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the return value of
https.getby also stating that it returns anhttp.ClientRequest. This brings it in line with thehttp.getdocumentation, improving consistency and reducing ambiguity.