test: deflake test-http2-options-max-headers-block-length

[lpinca]

The socket can be closed while data is still being written, causing an ECONNRESET error to be emitted on the client. Add a listener for it.

[lpinca]

See https://ci.nodejs.org/job/node-test-commit-osx/64691/nodes=osx13-arm64/testReport/junit/(root)/parallel/test_http2_options_max_headers_block_length/

---
duration_ms: 59.337
exitcode: 1
severity: fail
stack: |-
  node:events:485
        throw er; // Unhandled 'error' event
        ^

  Error: read ECONNRESET
      at TCP.onStreamRead (node:internal/stream_base_commons:216:20)
  Emitted 'error' event on ClientHttp2Session instance at:
      at emitClose (node:internal/http2/core:1123:10)
      at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
    errno: -54,
    code: 'ECONNRESET',
    syscall: 'read'
  }

  Node.js v24.0.0-pre
...

[lpinca]

It is also easy to reproduce locally.

$ npx envinfo --system

  System:
    OS: macOS 15.4.1
    CPU: (16) x64 Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz
    Memory: 9.61 GB / 32.00 GB
    Shell: 5.2.37 - /usr/local/bin/bash

Before

$ ./tools/test.py --repeat=1000 test/parallel/test-http2-options-max-headers-block-length.js 
=== release test-http2-options-max-headers-block-length ===                   
Path: parallel/test-http2-options-max-headers-block-length
node:events:485
      throw er; // Unhandled 'error' event
      ^

Error: read ECONNRESET
    at TCP.onStreamRead (node:internal/stream_base_commons:216:20)
Emitted 'error' event on ClientHttp2Session instance at:
    at emitClose (node:internal/http2/core:1123:10)
    at process.processTicksAndRejections (node:internal/process/task_queues:90:21) {
  errno: -54,
  code: 'ECONNRESET',
  syscall: 'read'
}

Node.js v24.0.0-pre
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-http2-options-max-headers-block-length.js

...

[00:13|% 100|+ 983|-  17]: Done

Failed tests:
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-http2-options-max-headers-block-length.js
....

After

$ ./tools/test.py --repeat=1000 test/parallel/test-http2-options-max-headers-block-length.js 
[00:13|% 100|+ 1000|-   0]: Done                                              

All tests passed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (e773e09) to head (4bde5e9).
Report is 20 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #57959   +/-   ##
=======================================
  Coverage   90.26%   90.27%           
=======================================
  Files         630      630           
  Lines      186137   186142    +5     
  Branches    36476    36480    +4     
=======================================
+ Hits       168018   168041   +23     
+ Misses      10979    10978    -1     
+ Partials     7140     7123   -17     

see 25 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions]

Failed to start CI

   ⚠  No approving reviews found
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/14574096677

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66407/

[joyeecheung]

It feels like a gotcha in the API to me that the client can get another error event if the goaway is not coming in fast enough when the client reads the socket (or is that a bug? cc @nodejs/http2 )..but then the docs doesn't say that it's impossible anyway.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66409/

[nodejs-github-bot]

Landed in 555aeb3