Skip to content

test: force GC in test-file-write-stream4 #57930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 18, 2025

Reduce test/parallel/test-file-write-stream4.js flakiness.

Refs: #57927

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 18, 2025
@lpinca
Copy link
Member Author

lpinca commented Apr 18, 2025

Alternative to #57927.

@lpinca
Copy link
Member Author

lpinca commented Apr 18, 2025

I think we can land this before #57927, and see if it has the desired effect. If it doesn't, we can revert and land #57927 instead.

Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure that this and the PR marking this test as flaky are mutually exclusive. We can do both then remove the flaky flag once we believe it has been fixed.

@lpinca lpinca force-pushed the deflake/test-file-write-stream4 branch 2 times, most recently from 4c82143 to 563da32 Compare April 18, 2025 18:26
@lpinca
Copy link
Member Author

lpinca commented Apr 18, 2025

In my opinion, landing both does not make much sense.

@lpinca
Copy link
Member Author

lpinca commented Apr 18, 2025

$ npx envinfo --system

  System:
    OS: macOS 15.4.1
    CPU: (16) x64 Intel(R) Xeon(R) W-2140B CPU @ 3.20GHz
    Memory: 1.66 GB / 32.00 GB
    Shell: 5.2.37 - /usr/local/bin/bash

Before the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
=== release test-file-write-stream4 ===                   
Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---


=== release test-file-write-stream4 ===                   
Path: parallel/test-file-write-stream4
Command: out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
--- TIMEOUT ---

...

[04:15|% 100|+ 982|-  18]: Done

Failed tests:
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js
out/Release/node --test-reporter=./test/common/test-error-reporter.js --test-reporter-destination=stdout /Users/luigi/code/node/test/parallel/test-file-write-stream4.js

...

After the patch

$ python3 tools/test.py --repeat=1000 test/parallel/test-file-write-stream4
[01:13|% 100|+ 1000|-   0]: Done                          

All tests passed.

Copy link

codecov bot commented Apr 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.27%. Comparing base (52d95f5) to head (5bfd30f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57930      +/-   ##
==========================================
+ Coverage   90.26%   90.27%   +0.01%     
==========================================
  Files         630      630              
  Lines      185933   185933              
  Branches    36450    36443       -7     
==========================================
+ Hits       167829   167853      +24     
+ Misses      10972    10964       -8     
+ Partials     7132     7116      -16     

see 27 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@nodejs-github-bot
Copy link
Collaborator

Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: nodejs#57927
@lpinca lpinca force-pushed the deflake/test-file-write-stream4 branch from 563da32 to 5bfd30f Compare April 19, 2025 07:59
@lpinca lpinca added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 19, 2025
@nodejs-github-bot
Copy link
Collaborator

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Apr 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 20, 2025
@nodejs-github-bot nodejs-github-bot merged commit 422529a into nodejs:main Apr 20, 2025
67 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 422529a

@lpinca lpinca deleted the deflake/test-file-write-stream4 branch April 20, 2025 18:37
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
aduh95 pushed a commit that referenced this pull request May 19, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 5, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 10, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
marco-ippolito pushed a commit that referenced this pull request Jun 11, 2025
Reduce `test/parallel/test-file-write-stream4.js` flakiness.

Refs: #57927
PR-URL: #57930
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: LiviaMedeiros <livia@cirno.name>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants