-
-
Notifications
You must be signed in to change notification settings - Fork 31.9k
test: force GC in test-file-write-stream4 #57930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: force GC in test-file-write-stream4 #57930
Conversation
Alternative to #57927. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that this and the PR marking this test as flaky are mutually exclusive. We can do both then remove the flaky flag once we believe it has been fixed.
4c82143
to
563da32
Compare
In my opinion, landing both does not make much sense. |
Before the patch
After the patch
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #57930 +/- ##
==========================================
+ Coverage 90.26% 90.27% +0.01%
==========================================
Files 630 630
Lines 185933 185933
Branches 36450 36443 -7
==========================================
+ Hits 167829 167853 +24
+ Misses 10972 10964 -8
+ Partials 7132 7116 -16 🚀 New features to boost your workflow:
|
Reduce `test/parallel/test-file-write-stream4.js` flakiness. Refs: nodejs#57927
563da32
to
5bfd30f
Compare
Landed in 422529a |
Reduce
test/parallel/test-file-write-stream4.js
flakiness.Refs: #57927