Skip to content

http2: give name to promisified connect() #57913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

LiviaMedeiros
Copy link
Member

Refs: #57899 for the eslint exception.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http2
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run. labels Apr 17, 2025
@LiviaMedeiros LiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Apr 17, 2025
@LiviaMedeiros
Copy link
Member Author

Changing to draft, this should be implemented differently.

@LiviaMedeiros LiviaMedeiros marked this pull request as draft April 17, 2025 16:39
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e61937b) to head (01ccc11).
Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #57913      +/-   ##
==========================================
+ Coverage   90.23%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      185786   185928     +142     
  Branches    36426    36434       +8     
==========================================
+ Hits       167653   167804     +151     
- Misses      11001    11021      +20     
+ Partials     7132     7103      -29     
Files with missing lines Coverage Δ
lib/internal/http2/core.js 95.50% <100.00%> (-0.06%) ⬇️

... and 31 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros
Copy link
Member Author

Superseded by #57916

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked PRs that are blocked by other issues or PRs. http2 Issues or PRs related to the http2 subsystem. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants