Skip to content

assert: support Float16Array in loose deep equality checks #57881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 19, 2025
Merged

assert: support Float16Array in loose deep equality checks #57881

merged 5 commits into from
Apr 19, 2025

Conversation

LiviaMedeiros
Copy link
Member

Depends on: #57879

@LiviaMedeiros LiviaMedeiros added the blocked PRs that are blocked by other issues or PRs. label Apr 14, 2025
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module. labels Apr 14, 2025
@LiviaMedeiros LiviaMedeiros added the assert Issues and PRs related to the assert subsystem. label Apr 14, 2025
BridgeAR
BridgeAR reviewed Apr 14, 2025
View reviewed changes
@LiviaMedeiros LiviaMedeiros added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 14, 2025
@aduh95 aduh95 added dont-land-on-v18.x dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. labels Apr 15, 2025
@LiviaMedeiros LiviaMedeiros force-pushed the assert-deepequal-float16array branch from 157b25b to 41b2697 Compare April 17, 2025 06:09
@LiviaMedeiros LiviaMedeiros marked this pull request as ready for review April 17, 2025 06:14
@LiviaMedeiros LiviaMedeiros removed the blocked PRs that are blocked by other issues or PRs. label Apr 17, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 17, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (e61937b) to head (a1c081f).
Report is 16 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57881      +/-   ##
==========================================
+ Coverage   90.23%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      185786   185790       +4     
  Branches    36426    36428       +2     
==========================================
+ Hits       167653   167679      +26     
  Misses      11001    11001              
+ Partials     7132     7110      -22
Files with missing lines Coverage Δ
lib/internal/util/comparisons.js 100.00% <100.00%> (ø)

... and 26 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@LiviaMedeiros
squash: fix test
a1c081f 
Number.EPSILON < 2**-24
@LiviaMedeiros LiviaMedeiros added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 18, 2025
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66362/

@LiviaMedeiros LiviaMedeiros added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 19, 2025
@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 19, 2025
@nodejs-github-bot nodejs-github-bot merged commit afd318d into nodejs:main Apr 19, 2025
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in afd318d

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@LiviaMedeiros @RafaelGSS
assert: support Float16Array in loose deep equality checks
953aa21 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@LiviaMedeiros @RafaelGSS
assert: support Float16Array in loose deep equality checks
7df9558 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
70a75d2 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
d3ed6f8 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@LiviaMedeiros @RafaelGSS
assert: support Float16Array in loose deep equality checks
3b774ef 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
2c1e289 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
8f82717 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
f3d5135 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
ec85d05 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
a2af829 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@LiviaMedeiros @aduh95
assert: support Float16Array in loose deep equality checks
4252dc7 
PR-URL: #57881
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR BridgeAR left review comments

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. dont-land-on-v20.x PRs that should not land on the v20.x-staging branch and should not be released in v20.x. needs-ci PRs that need a full CI run. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@LiviaMedeiros @nodejs-github-bot @jasnell @lpinca @BridgeAR @aduh95