test: add tests for REPL custom evals (second attempt)

[dario-piotrowicz]

this PR reintroduces the REPL custom eval tests that have been introduced in #57691 but reverted in #57793

the tests were working fine locally but caused failures in CI (like this one) the problem, I believe, being that the getReplOutput would return the output value right away even though the repl processing is asynchronous. Some small delay there is, I imagine, present in the CI runs and that's what I think was causing the issue.

I addressed this problem by returning a promise that resolves to the repl's output using the repl prompt as the signal to understand when the input processing has concluded, instead of returning the output right away.

[dario-piotrowicz]

cc. @tniessen, @lpinca 🙂 (sorry again for my earlier mistake on this change 🙇)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.16%. Comparing base (58e1cba) to head (a5ef49b).
Report is 34 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57850      +/-   ##
==========================================
- Coverage   90.17%   90.16%   -0.01%     
==========================================
  Files         636      637       +1     
  Lines      188028   188122      +94     
  Branches    36895    36908      +13     
==========================================
+ Hits       169547   169622      +75     
- Misses      11233    11237       +4     
- Partials     7248     7263      +15     

Files with missing lines	Coverage Δ
lib/repl.js	95.12% <ø> (-0.01%)	⬇️

... and 35 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[BridgeAR]

LGTM

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66283/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66285/

[lpinca]

There are still failures. Here is one in the latest CI run: https://ci.nodejs.org/job/node-test-commit-linux-containered/50117/nodes=ubuntu2204_sharedlibs_withoutssl_x64/testReport/(root)/parallel/test_repl_custom_eval/

---
duration_ms: 826.053
exitcode: 1
severity: fail
stack: |-
  > > > > Test failure: 'does show previews if `preview` is set to `true`'
  Location: test/parallel/test-repl-custom-eval.js:146:3
  AssertionError [ERR_ASSERTION]: The input did not match the regular expression /'Hello custom' \+ ' eval World!'\n\/\/ 'Hello custom eval World!'/. Input:

  "'Hello custom' + ' eval World!'"

      at TestContext.<anonymous> (/home/iojs/build/workspace/node-test-commit-linux-containered/test/parallel/test-repl-custom-eval.js:159:12)
      at process.processTicksAndRejections (node:internal/process/task_queues:105:5)
      at async Test.run (node:internal/test_runner/test:1069:7)
      at async Promise.all (index 7)
      at async Suite.run (node:internal/test_runner/test:1461:7)
      at async startSubtestAfterBootstrap (node:internal/test_runner/harness:308:3) {
    generatedMessage: true,
    code: 'ERR_ASSERTION',
    actual: "'Hello custom' + ' eval World!'",
    expected: /'Hello custom' \+ ' eval World!'\n\/\/ 'Hello custom eval World!'/,
    operator: 'match'
  }
...

[dario-piotrowicz]

oof... 😓

sorry about that, thanks @lpinca, I'll have a look 🙏

[dario-piotrowicz]

@lpinca I couldn't really reproduce the issue locally but I refactored the code to make it more robust regarding timing, I hope that this will fix the CI check, could you re-run the tests? 🙏

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: add tests for REPL custom evals
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/14532544242

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66342/

[github-actions]

Failed to start CI

   ⚠  Commits were pushed since the last approving review:
   ⚠  - test: add tests for REPL custom evals
   ✘  Refusing to run CI on potentially unsafe PR

https://github.com/nodejs/node/actions/runs/14833744376

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66607/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67395/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67398/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67404/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67410/

[dario-piotrowicz]

@jasnell, @BridgeAR and @gurgunday I've significantly changed the code since your last approval (for the better, the tests now are very much faster and more reliable than my previous iterations), could you please give this one a re-review when you get the chance? 🙏

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/67465/

[nodejs-github-bot]

Landed in d6dade5