Skip to content

src: improve error handling in node_env_var.cc #57767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 7, 2025
Merged

src: improve error handling in node_env_var.cc #57767

merged 1 commit into from
Apr 7, 2025

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 5, 2025

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Apr 5, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.25%. Comparing base (214e3d4) to head (ff56705).
Report is 24 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #57767      +/-   ##
==========================================
+ Coverage   90.24%   90.25%   +0.01%     
==========================================
  Files         630      630              
  Lines      185204   185204              
  Branches    36296    36294       -2     
==========================================
+ Hits       167133   167158      +25     
+ Misses      11003    10990      -13     
+ Partials     7068     7056      -12
Files with missing lines Coverage Δ
src/node_env_var.cc 83.23% <100.00%> (ø)

... and 30 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Apr 6, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 6, 2025
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2025 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/66077/ 💛

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 6, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 7, 2025
@nodejs-github-bot nodejs-github-bot merged commit 1540fc6 into nodejs:main Apr 7, 2025
72 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 1540fc6

@aduh95 aduh95 deleted the error-handling-cc branch April 8, 2025 08:24
JonasBa pushed a commit to JonasBa/node that referenced this pull request Apr 11, 2025
@aduh95 @JonasBa
src: improve error handling in node_env_var.cc
0d443a8 
PR-URL: nodejs#57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
d48d24f 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
2b0f65e 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 6, 2025
@aduh95
src: improve error handling in node_env_var.cc
abe4bd7 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@aduh95 @RafaelGSS
src: improve error handling in node_env_var.cc
310c6d0 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 16, 2025
@aduh95
src: improve error handling in node_env_var.cc
6625380 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
src: improve error handling in node_env_var.cc
5eee66b 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
src: improve error handling in node_env_var.cc
f950513 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
aduh95 added a commit that referenced this pull request May 17, 2025
@aduh95
src: improve error handling in node_env_var.cc
79df31b 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 added a commit that referenced this pull request May 19, 2025
@aduh95
src: improve error handling in node_env_var.cc
4754c69 
PR-URL: #57767
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@legendecas legendecas legendecas approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @jasnell @targos @legendecas