Skip to content

sqlite: add timeout options to DatabaseSync #57752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 12, 2025
Merged

sqlite: add timeout options to DatabaseSync #57752

merged 4 commits into from
Apr 12, 2025

Conversation

geeksilva97
Copy link
Contributor

@geeksilva97 geeksilva97 commented Apr 5, 2025 •
edited
Loading

Closes #57597

This PR adds the timeout option to the DatabaseSync constructor.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/sqlite

@geeksilva97 geeksilva97 added the wip Issues and PRs that are still a work in progress. label Apr 5, 2025
@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. sqlite Issues and PRs related to the SQLite subsystem. labels Apr 5, 2025
cjihrig
cjihrig reviewed Apr 5, 2025
View reviewed changes
@geeksilva97 geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch from 47ee71b to 2913993 Compare April 5, 2025 12:25
cjihrig
cjihrig reviewed Apr 5, 2025
View reviewed changes
@cjihrig cjihrig mentioned this pull request Apr 5, 2025
Closed
cjihrig
cjihrig reviewed Apr 6, 2025
View reviewed changes
cjihrig
cjihrig reviewed Apr 6, 2025
View reviewed changes
@geeksilva97 geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch 2 times, most recently from e046a85 to 35eaee0 Compare April 11, 2025 19:17
@geeksilva97 geeksilva97 self-assigned this Apr 11, 2025
@geeksilva97 geeksilva97 marked this pull request as ready for review April 11, 2025 19:18
@geeksilva97 geeksilva97 force-pushed the sqlite-dbsync-add-timeout branch from 35eaee0 to f686dd2 Compare April 11, 2025 19:20
@geeksilva97 geeksilva97 removed the wip Issues and PRs that are still a work in progress. label Apr 11, 2025
@geeksilva97 geeksilva97 requested review from cjihrig and jasnell April 11, 2025 19:21
@geeksilva97 geeksilva97 added the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Apr 11, 2025
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66205/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66206/

@geeksilva97 geeksilva97 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 11, 2025
@codecov Codecov
Copy link

codecov bot commented Apr 11, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 90.23%. Comparing base (86f86a2) to head (a6f75c9).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/node_sqlite.cc 83.33% 1 Missing and 1 partial ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #57752   +/-   ##
=======================================
  Coverage   90.22%   90.23%           
=======================================
  Files         630      630           
  Lines      185481   185496   +15     
  Branches    36364    36374   +10     
=======================================
+ Hits       167357   167380   +23     
+ Misses      11004    11001    -3     
+ Partials     7120     7115    -5
Files with missing lines Coverage Δ
src/node_sqlite.h 68.00% <100.00%> (+4.36%) ⬆️
src/node_sqlite.cc 80.49% <83.33%> (+0.01%) ⬆️

... and 23 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/66214/

@geeksilva97
Copy link
Contributor Author

It's official. CI doesn't like me 😅

I need a reapproval because of the commit that fixed linter issues in the markdown.

@geeksilva97 geeksilva97 requested a review from cjihrig April 12, 2025 15:35
@geeksilva97 geeksilva97 added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Apr 12, 2025
@cjihrig
Copy link
Contributor

cjihrig commented Apr 12, 2025

It's official. CI doesn't like me

To be fair, the CI doesn't like anyone.

@cjihrig cjihrig added commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Apr 12, 2025
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Apr 12, 2025
@nodejs-github-bot nodejs-github-bot merged commit 62426a7 into nodejs:main Apr 12, 2025
63 checks passed
@nodejs-github-bot
Copy link
Collaborator

Landed in 62426a7

RafaelGSS pushed a commit that referenced this pull request May 1, 2025
@geeksilva97 @RafaelGSS
sqlite: add timeout options to DatabaseSync
0835b68 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request May 1, 2025
Merged
RafaelGSS pushed a commit that referenced this pull request May 2, 2025
@geeksilva97 @RafaelGSS
sqlite: add timeout options to DatabaseSync
0df87e0 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
bc401dd 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 6, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
c6b3c1c 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
RafaelGSS pushed a commit that referenced this pull request May 14, 2025
@geeksilva97 @RafaelGSS
sqlite: add timeout options to DatabaseSync
11aa20f 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 16, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
a51ee78 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
8882bdb 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
8ce5c7c 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 17, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
f338eb4 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
aduh95 pushed a commit that referenced this pull request May 18, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
4e80bc9 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@github-actions github-actions bot mentioned this pull request May 19, 2025
Merged
aduh95 pushed a commit that referenced this pull request May 19, 2025
@geeksilva97 @aduh95
sqlite: add timeout options to DatabaseSync
c12cd2a 
PR-URL: #57752
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@AuntyEms AuntyEms mentioned this pull request Jun 8, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell Awaiting requested review from jasnell

Assignees

@geeksilva97 geeksilva97

Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. sqlite Issues and PRs related to the SQLite subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node:sqlite - add "timeout" as an option for initializing DatabaseSync
3 participants
@geeksilva97 @nodejs-github-bot @cjihrig