http2: skip writeHead if stream is closed

[islandryu]

Fixes: #57416

This issue can be reproduced by destroying the session immediately after the client sends a request.
You may occasionally see an error after running it a few times.

seq 100 | xargs -n1 -P100 node client.js

// server.js
const http2 = require('http2');
const server = http2.createServer((req, res) => {
  setTimeout(() => {
    res.writeHead(200, { 'content-type': 'text/plain' });
    res.end('Hello from HTTP/2 server!\n');
  }, 100); 
});

server.listen(6000, () => {});

// client.js
const http2 = require('http2');

const client = http2.connect('http://localhost:6000');
const req = client.request({ ':path': '/' });
setTimeout(() => {
    client.destroy();
}, 100);

If writeHead() is called after the server receives a GOAWAY frame but before it sends a RST_STREAM, the server may enter an error state.

After the GOAWAY frame is received, the http2Stream is immediately closed.
However, the response object (res) is only marked as closed after the RST_STREAM frame is sent.

Currently, writeHead() checks whether the response object is closed, but it does not check whether the stream itself has been closed.

how to fix

Even if the RST_STREAM frame hasn't been sent yet, it seems like it might already be queued when the http2Stream is closed.
So this change skips writeHead() when the stream is already closed.

[nodejs-github-bot]

Review requested:

• @nodejs/http2
• @nodejs/net

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.24%. Comparing base (78af51c) to head (ddca2b5).
Report is 36 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #57686      +/-   ##
==========================================
+ Coverage   90.22%   90.24%   +0.01%     
==========================================
  Files         630      630              
  Lines      185074   185074              
  Branches    36222    36221       -1     
==========================================
+ Hits       166985   167013      +28     
+ Misses      11041    11034       -7     
+ Partials     7048     7027      -21     

Files with missing lines	Coverage Δ
lib/internal/http2/compat.js	96.94% <100.00%> (ø)

... and 24 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[mcollina]

lgtm

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65904/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65920/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65922/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65964/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/65997/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/66022/

[nodejs-github-bot]

Landed in b140283